Skip to content

feat(auth): verify API client connectivity in set_api_client#1067

Merged
openshift-merge-bot[bot] merged 1 commit into
mainfrom
eager-auth
Apr 30, 2026
Merged

feat(auth): verify API client connectivity in set_api_client#1067
openshift-merge-bot[bot] merged 1 commit into
mainfrom
eager-auth

Conversation

@szaher

@szaher szaher commented Apr 30, 2026

Copy link
Copy Markdown
Contributor

Add an authentication check when setting a custom API client to
catch misconfigured or invalid clients early. The verification
calls AuthenticationApi.get_api_group() to confirm the client
can reach the Kubernetes API server before proceeding.

Issue link

What changes have been made

Verification steps

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

  Add an authentication check when setting a custom API client to
  catch misconfigured or invalid clients early. The verification
  calls AuthenticationApi.get_api_group() to confirm the client
  can reach the Kubernetes API server before proceeding.

Signed-off-by: Saad Zaher <szaher@redhat.com>
@openshift-ci
openshift-ci Bot requested review from DavidAdaRH and chipspeak April 30, 2026 11:14
@codecov

codecov Bot commented Apr 30, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.56%. Comparing base (e5cdf08) to head (9a10717).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1067   +/-   ##
=======================================
  Coverage   96.56%   96.56%           
=======================================
  Files          23       23           
  Lines        2270     2272    +2     
=======================================
+ Hits         2192     2194    +2     
  Misses         78       78           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@openshift-ci

openshift-ci Bot commented Apr 30, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chipspeak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 30, 2026
@openshift-merge-bot
openshift-merge-bot Bot merged commit a9f14f9 into main Apr 30, 2026
20 checks passed
@szaher
szaher deleted the eager-auth branch May 5, 2026 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants