feat(auth): verify API client connectivity in set_api_client#1067
Merged
Conversation
Add an authentication check when setting a custom API client to catch misconfigured or invalid clients early. The verification calls AuthenticationApi.get_api_group() to confirm the client can reach the Kubernetes API server before proceeding. Signed-off-by: Saad Zaher <szaher@redhat.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1067 +/- ##
=======================================
Coverage 96.56% 96.56%
=======================================
Files 23 23
Lines 2270 2272 +2
=======================================
+ Hits 2192 2194 +2
Misses 78 78 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
chipspeak
approved these changes
Apr 30, 2026
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chipspeak The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an authentication check when setting a custom API client to
catch misconfigured or invalid clients early. The verification
calls AuthenticationApi.get_api_group() to confirm the client
can reach the Kubernetes API server before proceeding.
Issue link
What changes have been made
Verification steps
Checks