Skip to content

Update version update workflow #1072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-bot merged 2 commits into from
May 6, 2026
Merged

Update version update workflow #1072

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c81665b
test: parameterize rayVersion in test YAMLs
chipspeak May 5, 2026
ebca67e
ci(workflows): refactor update-versions workflow
kryanbeane May 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
410 changes: 236 additions & 174 deletions .github/workflows/update-versions.yaml
View file
Open in desktop

Large diffs are not rendered by default.

1 change: 1 addition & 0 deletions src/codeflare_sdk/common/utils/unit_test_support.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -287,6 +287,7 @@ def get_expected_image():
def get_template_variables():
return {
"image": get_expected_image(),
"ray_version": constants.RAY_VERSION,
}


Expand Down
9 changes: 5 additions & 4 deletions src/codeflare_sdk/ray/cluster/test_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@
# See the License for the specific language governing permissions and
# limitations under the License.

import filecmp
import os
from pathlib import Path

Expand Down Expand Up @@ -96,11 +95,13 @@ def test_config_creation_all_parameters(mocker):
assert cluster.config.volumes == volumes
assert cluster.config.volume_mounts == volume_mounts

assert filecmp.cmp(
f"{cluster_dir}test-all-params.yaml",
with open(f"{cluster_dir}test-all-params.yaml", "r") as f:
actual = yaml.load(f, Loader=yaml.FullLoader)
expected = apply_template(
f"{expected_clusters_dir}/ray/unit-test-all-params.yaml",
shallow=True,
get_template_variables(),
)
assert actual == expected


def test_config_creation_wrong_type():
Expand Down
2 changes: 1 addition & 1 deletion tests/test_cluster_yamls/kueue/ray_cluster_kueue.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ spec:
name: odh-trusted-ca-bundle
optional: true
name: odh-ca-cert
rayVersion: 2.52.1
rayVersion: ${ray_version}
workerGroupSpecs:
- groupName: small-group-unit-test-cluster-kueue
maxReplicas: 2
Expand Down
2 changes: 1 addition & 1 deletion tests/test_cluster_yamls/ray/default-ray-cluster.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ spec:
name: odh-trusted-ca-bundle
optional: true
name: odh-ca-cert
rayVersion: 2.52.1
rayVersion: ${ray_version}
workerGroupSpecs:
- groupName: small-group-default-cluster
maxReplicas: 1
Expand Down
2 changes: 1 addition & 1 deletion tests/test_cluster_yamls/ray/unit-test-all-params.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ spec:
name: odh-trusted-ca-bundle
optional: true
name: odh-ca-cert
rayVersion: 2.52.1
rayVersion: ${ray_version}
workerGroupSpecs:
- groupName: small-group-test-all-params
maxReplicas: 10
Expand Down
2 changes: 1 addition & 1 deletion tests/test_cluster_yamls/support_clusters/test-rc-a.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ spec:
name: odh-trusted-ca-bundle
optional: true
name: odh-ca-cert
rayVersion: 2.52.1
rayVersion: ${ray_version}
workerGroupSpecs:
- groupName: small-group-test-cluster-a
maxReplicas: 1
Expand Down
2 changes: 1 addition & 1 deletion tests/test_cluster_yamls/support_clusters/test-rc-b.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ spec:
name: odh-trusted-ca-bundle
optional: true
name: odh-ca-cert
rayVersion: 2.52.1
rayVersion: ${ray_version}
workerGroupSpecs:
- groupName: small-group-test-rc-b
maxReplicas: 1
Expand Down
Loading