Skip to content

no-jira: add e2e tests rules#1088

Merged
pawelpaszki merged 1 commit into
project-codeflare:mainfrom
pawelpaszki:no-jira-e2e-tests-rules
May 13, 2026
Merged

no-jira: add e2e tests rules#1088
pawelpaszki merged 1 commit into
project-codeflare:mainfrom
pawelpaszki:no-jira-e2e-tests-rules

Conversation

@pawelpaszki

Copy link
Copy Markdown
Contributor

Issue link

What changes have been made

no-jira: add e2e tests rules

Verification steps

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

@openshift-ci-robot

Copy link
Copy Markdown
Collaborator

@pawelpaszki: This pull request explicitly references no jira issue.

Details

In response to this:

Issue link

What changes have been made

no-jira: add e2e tests rules

Verification steps

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@codecov

codecov Bot commented May 13, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.61%. Comparing base (cf2b4c0) to head (944f33a).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1088   +/-   ##
=======================================
  Coverage   96.61%   96.61%           
=======================================
  Files          23       23           
  Lines        2306     2306           
=======================================
  Hits         2228     2228           
  Misses         78       78           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kryanbeane kryanbeane left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these look cool, I'm not sure on best practices with rules so my review doesn't mean too much but I did a grill-me session (the skill me and Cathal have been talking about recently) and it didn't point out anything that urgently needs fixing so lgtm!

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label May 13, 2026
@openshift-ci

openshift-ci Bot commented May 13, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kryanbeane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 13, 2026
@pawelpaszki pawelpaszki merged commit ce6b6f6 into project-codeflare:main May 13, 2026
23 of 26 checks passed
@pawelpaszki pawelpaszki deleted the no-jira-e2e-tests-rules branch May 13, 2026 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants