no-jira: add e2e tests rules#1088
Conversation
|
@pawelpaszki: This pull request explicitly references no jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1088 +/- ##
=======================================
Coverage 96.61% 96.61%
=======================================
Files 23 23
Lines 2306 2306
=======================================
Hits 2228 2228
Misses 78 78 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
kryanbeane
left a comment
There was a problem hiding this comment.
these look cool, I'm not sure on best practices with rules so my review doesn't mean too much but I did a grill-me session (the skill me and Cathal have been talking about recently) and it didn't point out anything that urgently needs fixing so lgtm!
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kryanbeane The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Issue link
What changes have been made
no-jira: add e2e tests rules
Verification steps
Checks