Skip to content

fix: port forward for local interactive tests#834

Merged
openshift-merge-bot[bot] merged 2 commits into
project-codeflare:mainfrom
kryanbeane:RHOAIENG-25143
Jun 4, 2025
Merged

fix: port forward for local interactive tests#834
openshift-merge-bot[bot] merged 2 commits into
project-codeflare:mainfrom
kryanbeane:RHOAIENG-25143

Conversation

@kryanbeane

Copy link
Copy Markdown
Contributor

Issue link

What changes have been made

Verification steps

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 3, 2025
@codecov

codecov Bot commented Jun 3, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.45%. Comparing base (028d0d5) to head (7ec22e2).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #834   +/-   ##
=======================================
  Coverage   92.45%   92.45%           
=======================================
  Files          24       24           
  Lines        1419     1419           
=======================================
  Hits         1312     1312           
  Misses        107      107           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kryanbeane kryanbeane force-pushed the RHOAIENG-25143 branch 5 times, most recently from 80fe999 to a8c55be Compare June 3, 2025 15:00
@kryanbeane

kryanbeane commented Jun 3, 2025

Copy link
Copy Markdown
Contributor Author

@kryanbeane kryanbeane marked this pull request as ready for review June 3, 2025 15:27
@openshift-ci openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 3, 2025
@openshift-ci openshift-ci Bot requested a review from dimakis June 3, 2025 15:27

@chipspeak chipspeak left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and thanks for all the work on this!

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jun 4, 2025
@openshift-ci

openshift-ci Bot commented Jun 4, 2025

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chipspeak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 4, 2025
@openshift-merge-bot openshift-merge-bot Bot merged commit 78ec732 into project-codeflare:main Jun 4, 2025
19 checks passed
@kryanbeane kryanbeane deleted the RHOAIENG-25143 branch June 4, 2025 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants