feat: add comment about tearing down ray clusters to cluster.apply()#837
Merged
openshift-merge-bot[bot] merged 1 commit intoJun 10, 2025
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #837 +/- ##
=======================================
Coverage 92.48% 92.48%
=======================================
Files 24 24
Lines 1423 1423
=======================================
Hits 1316 1316
Misses 107 107 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
pawelpaszki
approved these changes
Jun 10, 2025
chipspeak
self-requested a review
June 10, 2025 14:34
chipspeak
approved these changes
Jun 10, 2025
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chipspeak, pawelpaszki The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
Bot
merged commit Jun 10, 2025
5c2495d
into
project-codeflare:main
19 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue link
What changes have been made
Add output logs to
cluster.apply()about tearing down Ray ClustersVerification steps
Checks