Skip to content

e2e test#874

Closed
chipspeak wants to merge 2 commits into
project-codeflare:mainfrom
chipspeak:e2e-failure-test
Closed

e2e test#874
chipspeak wants to merge 2 commits into
project-codeflare:mainfrom
chipspeak:e2e-failure-test

Conversation

@chipspeak

Copy link
Copy Markdown
Contributor

Testing e2e failure for a missing -y in an install. Just attempting to verify that its occurring on main also.

Signed-off-by: Pat O'Connor <paoconno@redhat.com>
@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 1, 2025
@openshift-ci

openshift-ci Bot commented Aug 1, 2025

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign laurafitzgerald for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@chipspeak

Copy link
Copy Markdown
Contributor Author

/hold

@chipspeak chipspeak marked this pull request as ready for review August 1, 2025 10:28
@openshift-ci openshift-ci Bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Aug 1, 2025
@codecov

codecov Bot commented Aug 1, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.47%. Comparing base (326434d) to head (ab0e2f2).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #874   +/-   ##
=======================================
  Coverage   92.47%   92.47%           
=======================================
  Files          24       24           
  Lines        1396     1396           
=======================================
  Hits         1291     1291           
  Misses        105      105           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: Pat O'Connor <paoconno@redhat.com>
@chipspeak

Copy link
Copy Markdown
Contributor Author

it fails here to installing dnsmasq. I think we'll need to add a -y flag to codeflare-common . Within my RayJobs PR I've copied the contents of the external action and added the flag and it seems to be progressing past this failure now.

@chipspeak chipspeak closed this Aug 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant