Equality Vs Identity

[Boomatang]

In a number of location there were comparisons against None, and boolean values that were using equality comparisons. This can lead to bugs caused by false positives. Bug of this nature are hard track down.

While I could not track down an instance of the bug, this PR introduces the correct pattern of using identity comparisons to the code base. Hopefully, the pattern will be followed within future work, and no unexpected bugs arise.

Equality and Identity by example

In the repl equality and identity can easily be seen.

>>> 1 == True # Equality
True
>>> 1 is True # Identity
False

Classes defining a custom __eq__() methods can have logic error that allowing None equality to be true.

class Foo:
  def __eq__(self, other):
    return True

bar = Foo()

if bar == None:
  print("bar is None !!!")

if bar is not None:
  print("but bar is also not None !!!")

More on comparisons can be found at https://docs.python.org/3/reference/expressions.html#comparisons

Verification

There is no fundamental change to the logic. All tests should pass as expected.

Note: Locally I was not setup to run e2e tests.

[codecov]

Codecov Report

❌ Patch coverage is 95.83333% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 95.96%. Comparing base (70098a0) to head (821394f).
⚠️ Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
src/codeflare_sdk/ray/cluster/cluster.py	92.85%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #916      +/-   ##
==========================================
- Coverage   95.96%   95.96%   -0.01%     
==========================================
  Files          23       23              
  Lines        2208     2203       -5     
==========================================
- Hits         2119     2114       -5     
  Misses         89       89              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[kryanbeane]

/override verify-3_widget_example

[openshift-ci]

@kryanbeane: Overrode contexts on behalf of kryanbeane: verify-3_widget_example

Details

In response to this:

/override verify-3_widget_example

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[kryanbeane]

thanks for the contribution Jim and apologies it took so long to get merged!

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kryanbeane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [kryanbeane]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment