Skip to content

update mtls secret data name for cert generation#936

Merged
openshift-merge-bot[bot] merged 3 commits into
project-codeflare:mainfrom
laurafitzgerald:RHOAIENG-38319
Nov 7, 2025
Merged

update mtls secret data name for cert generation#936
openshift-merge-bot[bot] merged 3 commits into
project-codeflare:mainfrom
laurafitzgerald:RHOAIENG-38319

Conversation

@laurafitzgerald

Copy link
Copy Markdown
Contributor

@codecov

codecov Bot commented Nov 7, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 87.50000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 94.28%. Comparing base (1c4e8a0) to head (b59eacb).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
src/codeflare_sdk/common/utils/generate_cert.py 87.50% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #936      +/-   ##
==========================================
- Coverage   94.34%   94.28%   -0.07%     
==========================================
  Files          24       24              
  Lines        2070     2083      +13     
==========================================
+ Hits         1953     1964      +11     
- Misses        117      119       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread src/codeflare_sdk/common/utils/generate_cert.py
@openshift-ci openshift-ci Bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 7, 2025
@openshift-ci

openshift-ci Bot commented Nov 7, 2025

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kryanbeane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kryanbeane

Copy link
Copy Markdown
Contributor

/override kubernetes

@openshift-ci

openshift-ci Bot commented Nov 7, 2025

Copy link
Copy Markdown
Contributor

@kryanbeane: Overrode contexts on behalf of kryanbeane: kubernetes

Details

In response to this:

/override kubernetes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot openshift-merge-bot Bot merged commit 1d96cb2 into project-codeflare:main Nov 7, 2025
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants