use kube-authkit for better k8s authentication#970
Conversation
Signed-off-by: Saad Zaher <szaher@redhat.com>
Signed-off-by: Saad Zaher <szaher@redhat.com>
Signed-off-by: Saad Zaher <szaher@redhat.com>
Signed-off-by: Saad Zaher <szaher@redhat.com>
Signed-off-by: Saad Zaher <szaher@redhat.com>
Replace global no-op of kubeconfig loaders with targeted test-only mocks so tests that assert loader behavior can still patch them locally. Add fake k8s clients (AuthenticationApi, CoreV1Api, CustomObjectsApi) implementing the methods used by unit tests (get_api_group, read_namespaced_secret, list_namespaced_custom_object, list_cluster_custom_object, get/create/delete_namespaced_custom_object, etc.). Create minimal resource YAMLs under $HOME/.codeflare/resources and TLS files in a tmp CWD so tests do not raise FileNotFoundError. Test-only change: no production code modified. Signed-off-by: Saad Zaher <szaher@redhat.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #970 +/- ##
==========================================
+ Coverage 95.91% 95.96% +0.05%
==========================================
Files 22 23 +1
Lines 2130 2206 +76
==========================================
+ Hits 2043 2117 +74
- Misses 87 89 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Saad Zaher <szaher@redhat.com>
Signed-off-by: Saad Zaher <szaher@redhat.com>
Signed-off-by: Saad Zaher <szaher@redhat.com>
Signed-off-by: Saad Zaher <szaher@redhat.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kryanbeane The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
holding for more reviews |
Signed-off-by: Saad Zaher <szaher@redhat.com>
|
New changes are detected. LGTM label has been removed. |
Co-authored-by: Bryan Keane <bryankeane0@gmail.com>
Signed-off-by: Saad Zaher <szaher@redhat.com>
|
I have verified the changes on non-byoidc cluster with provided steps from the description and executed e2e tests on byoidc and non-byoidc clusters (with additional changes for the e2e tests). all looks good |
Issue link
What changes have been made
Verification steps
Use the following python snippet to validate everything works with authkit
Checks