no-jira: no ttl long lived clusters

[kryanbeane]

Issue link

N/A

What changes have been made

No jira for this, came up from Cathal encountering this in a cluster. With long lived clusters, we shouldn't allow TTL field to be set as this is only for lifecycled clusters.

Verification steps

• Run poetry build
• Install custom build

%pip install ./codeflare_sdk-0.34.0-py3-none-any.whl --force-reinstall 

• Verify that you can't create a RayJob with TTL set when targetting an existing cluster

prod_job = RayJob(
    job_name='job',
    namespace='default',
    cluster_name='not-a-cluster',
    entrypoint="python nightly.py",
    ttl_seconds_after_finished=300,
)

• The above should fail, you shouldn't need to run this on a cluster or anything, the object not being able to initialize and throwing an error should suffice

Checks

• I've made sure the tests are passing.
• Testing Strategy
  • Unit tests
  • Manual tests
  • Testing is not required for this change

[openshift-ci-robot]

@kryanbeane: This pull request explicitly references no jira issue.

Details

In response to this:

Issue link

N/A

What changes have been made

No jira for this, came up from Cathal encountering this in a cluster. With long lived clusters, we shouldn't allow TTL field to be set as this is only for lifecycled clusters.

Verification steps

Checks

• I've made sure the tests are passing.
• Testing Strategy
  • Unit tests
  • Manual tests
  • Testing is not required for this change

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.87%. Comparing base (4e4a181) to head (90ea08b).
⚠️ Report is 9 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #987   +/-   ##
=======================================
  Coverage   95.87%   95.87%           
=======================================
  Files          22       22           
  Lines        2132     2134    +2     
=======================================
+ Hits         2044     2046    +2     
  Misses         88       88           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[laurafitzgerald]

Changes look good. I haven't done the verification. Will leave that for someone else.

[pawelpaszki]

Confirmed expected behaviour:

ValueError: ❌ Configuration Error: 'ttl_seconds_after_finished' cannot be set when targeting an existing cluster (via 'cluster_name').
TTL controls automatic cleanup of RayJob-managed clusters, which only applies when creating a new cluster via 'cluster_config'.
For existing clusters, the RayJob CR will remain after completion for inspection.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pawelpaszki

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [pawelpaszki]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment