Skip to content

RHAIENG-1795: test using gateway config as fallback for constructing dashboard url#993

Merged
openshift-merge-bot[bot] merged 4 commits into
mainfrom
test-gateway-config-url-generation
Jun 11, 2026
Merged

RHAIENG-1795: test using gateway config as fallback for constructing dashboard url#993
openshift-merge-bot[bot] merged 4 commits into
mainfrom
test-gateway-config-url-generation

Conversation

@kryanbeane

@kryanbeane kryanbeane commented Jan 28, 2026

Copy link
Copy Markdown
Contributor

Issue link

RHAIENG-1795

What changes have been made

Added fallback to use gateway config for constructing dashboard url

Verification steps

Hard to verify - @CathalOConnorRH has verified I believe that without usual gateway object, this works as an alternative

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

@openshift-ci openshift-ci Bot requested review from dimakis and szaher January 28, 2026 15:44
@openshift-ci-robot

openshift-ci-robot commented Jan 28, 2026 •
edited by openshift-ci Bot
Loading

Copy link
Copy Markdown
Collaborator

@kryanbeane: This pull request references RHAIENG-1795 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Issue link

RHAIENG-1795

What changes have been made

Added fallback to use gateway config for constructing dashboard url

Verification steps

Hard to verify - @CathalOConnorRH has verified I believe that without usual gateway object, this works as an alternative

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@codecov

codecov Bot commented Jan 28, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.47%. Comparing base (dff2117) to head (f333497).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #993      +/-   ##
==========================================
+ Coverage   96.46%   96.47%   +0.01%     
==========================================
  Files          23       23              
  Lines        2318     2329      +11     
==========================================
+ Hits         2236     2247      +11     
  Misses         82       82

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kryanbeane
Add tests for GatewayConfig CR fallback in dashboard URL generation
9809694 
Cover the new GatewayConfig hostname resolution path to satisfy
codecov/patch coverage requirements.
@kryanbeane kryanbeane force-pushed the test-gateway-config-url-generation branch from 77acaf7 to 9809694 Compare June 11, 2026 09:59
kryanbeane and others added 2 commits June 11, 2026 11:11
@kryanbeane
Mock get_cluster_custom_object in existing httproute test
a3e1b97 
The GatewayConfig fallback code calls get_cluster_custom_object,
which was previously unmocked in the "no hostname" test cases.
On CI, the unmocked call could return stale data instead of
raising, causing the test to get a URL when it expected None.
@kryanbeane
Merge branch 'main' into test-gateway-config-url-generation
f333497
@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jun 11, 2026
@openshift-ci

openshift-ci Bot commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pawelpaszki

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 11, 2026
@openshift-merge-bot openshift-merge-bot Bot merged commit e928698 into main Jun 11, 2026
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pawelpaszki pawelpaszki pawelpaszki approved these changes

@dimakis dimakis Awaiting requested review from dimakis

@szaher szaher Awaiting requested review from szaher

Assignees

@pawelpaszki pawelpaszki

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kryanbeane @openshift-ci-robot @pawelpaszki