Skip to content

test: byoidc compatibility#995

Merged
pawelpaszki merged 1 commit into
project-codeflare:mainfrom
pawelpaszki:RHOAIENG-46762
Jan 30, 2026
Merged

test: byoidc compatibility#995
pawelpaszki merged 1 commit into
project-codeflare:mainfrom
pawelpaszki:RHOAIENG-46762

Conversation

@pawelpaszki

Copy link
Copy Markdown
Contributor

Issue link

RHOAIENG-46762

What changes have been made

test: byoidc compatibility

Verification steps

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

@openshift-ci openshift-ci Bot requested review from kryanbeane and szaher January 29, 2026 16:05
@codecov

codecov Bot commented Jan 29, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.96%. Comparing base (035e935) to head (ae9a251).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #995   +/-   ##
=======================================
  Coverage   95.96%   95.96%           
=======================================
  Files          23       23           
  Lines        2208     2208           
=======================================
  Hits         2119     2119           
  Misses         89       89           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pawelpaszki pawelpaszki added test-guided-notebooks Run PR check to verify Guided notebooks test-ui-notebooks Run PR check to verify UI notebooks test-additional-notebooks labels Jan 30, 2026

@kryanbeane kryanbeane left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

think this is my only comment. other than that loooks good!

Comment thread tests/e2e/support.py
@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jan 30, 2026
@openshift-ci

openshift-ci Bot commented Jan 30, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kryanbeane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 30, 2026
@pawelpaszki pawelpaszki merged commit 70098a0 into project-codeflare:main Jan 30, 2026
17 of 26 checks passed
@pawelpaszki pawelpaszki deleted the RHOAIENG-46762 branch January 30, 2026 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. test-additional-notebooks test-guided-notebooks Run PR check to verify Guided notebooks test-ui-notebooks Run PR check to verify UI notebooks

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants