Skip to content

bump buildkit to v0.28.1#1000

Merged
cpuguy83 merged 1 commit into
project-dalec:mainfrom
DannyBrito:dannybrito/bump-buildkit
Mar 26, 2026
Merged

bump buildkit to v0.28.1#1000
cpuguy83 merged 1 commit into
project-dalec:mainfrom
DannyBrito:dannybrito/bump-buildkit

Conversation

@DannyBrito
Copy link
Copy Markdown
Contributor

@DannyBrito DannyBrito commented Mar 26, 2026

What this PR does / why we need it:
dependabot trying to update to newer version of buildkit but fails as dalec is in lower version https://github.com/Azure/dalec-build-defs/pull/5646 as newever version seems to require new method SetImageBlobOption https://github.com/moby/buildkit/blame/v0.28.1/client/llb/source.go#L107

Signed-off-by: Danny Brito <54994380+DannyBrito@users.noreply.github.com>
Copilot AI review requested due to automatic review settings March 26, 2026 16:17
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates Dalec’s Go module dependencies to support BuildKit v0.28.1 (needed by downstream consumers) and adds the missing llb.ConstraintsOpt hook required by the newer BuildKit LLB API.

Changes:

  • Bump github.com/moby/buildkit to v0.28.1 (and refresh transitive deps in go.sum).
  • Extend ConstraintsOptFunc to implement the new SetImageBlobOption(*llb.ImageBlobInfo) method.
  • Update go.mod Go version directive.

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.

File Description
helpers.go Adds ConstraintsOptFunc.SetImageBlobOption to satisfy the updated BuildKit llb.ConstraintsOpt interface.
go.mod Bumps BuildKit and related Go module versions; updates the go directive.
go.sum Records updated dependency checksums after the module upgrades.

Comment thread go.mod
module github.com/project-dalec/dalec

go 1.25.0
go 1.25.5
Copy link

Copilot AI Mar 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The go directive should track the language version (typically 1.25 / 1.25.0), not a specific patch release. Using go 1.25.5 can also drift from CI which sets up go-version: '1.25' and may cause module parsing/tooling issues on environments that don’t recognize patch-level go directives. Consider reverting this to go 1.25.0 (or go 1.25) and, if you need to pin the toolchain patch, add a separate toolchain go1.25.5 line instead.

Suggested change
go 1.25.5
go 1.25.0
toolchain go1.25.5

Copilot uses AI. Check for mistakes.
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we undo this change, by chance?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think so seems bump came from buildkit itself?
https://github.com/moby/buildkit/blob/v0.28.1/go.mod#L3

@cpuguy83 cpuguy83 merged commit 53ff16f into project-dalec:main Mar 26, 2026
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants