fix: correct series file entries and sort patch keys in deb target#1024
Merged
Conversation
Fix two bugs in the deb patch handling: 1. sourcePatchesDir wrote the target source name instead of the patch source name to the series file, causing incorrect documentation. 2. createPatchScript iterated over the Patches map without sorting, causing non-deterministic patch application order unlike the RPM target which sorts keys. Add unit tests for both issues. Signed-off-by: Burak Ok <burakok@microsoft.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes two debian patch-handling bugs in Dalec’s DEB packaging implementation to make patch documentation and patch application order deterministic (aligning behavior with the RPM target).
Changes:
- Write the correct patch source names to the
seriesfile generated underdebian/dalec/patches/.... - Sort
spec.Patchesmap keys before generating the DEB patch application script to ensure deterministic order. - Add unit tests covering both the
seriesfile contents and the sorted patch script output.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packaging/linux/deb/debroot.go | Fixes series file entries and ensures deterministic patch script generation by sorting patch keys. |
| packaging/linux/deb/debroot_patch_test.go | Adds regression tests for correct series contents and deterministic patch ordering in the generated script. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix two bugs in the deb patch handling:
Add unit tests for both issues.