Skip to content

test: fix frontend coverage covdata extraction#1049

Closed
cpuguy83 wants to merge 3 commits into
project-dalec:mainfrom
cpuguy83:gpt55/pr-961-coverage-confirm
Closed

test: fix frontend coverage covdata extraction#1049
cpuguy83 wants to merge 3 commits into
project-dalec:mainfrom
cpuguy83:gpt55/pr-961-coverage-confirm

Conversation

@cpuguy83
Copy link
Copy Markdown
Collaborator

@cpuguy83 cpuguy83 commented May 1, 2026

Summary

  • Fix frontend coverage covdata filenames to match Go's covmeta.<hash> and covcounters.<hash>.<pid>.<timestamp> expectations.
  • Extract the covdata meta hash from the metadata header instead of hashing the full metadata payload.
  • Preserve coverage payload extraction from BuildKit-wrapped gRPC errors and assert error-path covdata converts to non-zero coverage.

Verification

  • go test --test.short --timeout=10m ./cmd/frontend ./test/testenv ./internal/frontendcoverage
  • go test -timeout=15m -v ./test -run TestFrontendCoverageExportedOnSolveError

This is based on #961 and intended to confirm/fix the frontend coverage collection path.

kartikjoshi21 and others added 3 commits April 22, 2026 08:23
This PR adds automated Go coverage reporting to the CI pipeline.
Unit and integration tests now generate coverage profiles
(one per integration matrix suite).
It also collects coverage for the Dalec BuildKit frontend by
building it with coverage enabled and exporting its covdata
during solves.

A new coverage-report job downloads all profiles, merges them,
and uploads a combined report (including an index.html coverage page)
as a workflow artifact, plus a summary in the Actions run.

Fixes: project-dalec#889
Signed-off-by: Kartik Joshi <karikjoshi21@gmail.com>
Signed-off-by: Kartik Joshi <karikjoshi21@gmail.com>
Signed-off-by: Brian Goff <cpuguy83@gmail.com>
@cpuguy83 cpuguy83 closed this May 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants