Conversation
This was referenced Mar 14, 2026
Closed
casaroli
force-pushed
the
wasi-sysroot
branch
5 times, most recently
from
1825851 to
200d4e8
Compare
casaroli
changed the title
Currently, since WASI-SDK only provides binaries for a few platforms, excluding RISCV32, and we want to provide support for those, it will be better if we use "upstream" clang to build the WASM modules. So, instead of wasi-sdk, we just need the sysroot. Signed-off-by: Marco Casaroli <marco.casaroli@gmail.com>
Signed-off-by: Marco Casaroli <marco.casaroli@gmail.com>
Signed-off-by: Marco Casaroli <marco.casaroli@gmail.com>
Signed-off-by: Marco Casaroli <marco.casaroli@gmail.com>
Signed-off-by: Marco Casaroli <marco.casaroli@gmail.com>
Signed-off-by: Marco Casaroli <marco.casaroli@gmail.com>
Signed-off-by: Marco Casaroli <marco.casaroli@gmail.com>
Signed-off-by: Marco Casaroli <marco.casaroli@gmail.com>
Signed-off-by: Marco Casaroli <marco.casaroli@gmail.com>
This reverts commit 33f3806. Signed-off-by: Marco Casaroli <marco.casaroli@gmail.com>
Signed-off-by: Marco Casaroli <marco.casaroli@gmail.com>
Signed-off-by: Marco Casaroli <marco.casaroli@gmail.com>
kr-t
approved these changes
Mar 24, 2026
| jobs: | ||
| build: | ||
| name: Build Samples | ||
| runs-on: "ubuntu-22.04" |
Collaborator
There was a problem hiding this comment.
nit: the latest LTS is 24.04 and is more widely used. Maybe we want to use that.
Collaborator
Author
There was a problem hiding this comment.
it is just docker
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
TODO (in next PRs):