Fix #7: increase FPS spinbox maximum to 999#15
Merged
Conversation
The maxFPSSpinBox had no explicit maximum, defaulting to Qt's 99. Users with high-refresh displays could set FPS > 99 in config.inp but couldn't change it in the UI without editing the file. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Updates the Qt config dialog to allow users to set and persist FPS limits above 99 (up to 999), matching what can already be specified in config.inp.
Changes:
- Adds an explicit
maximumproperty of999to themaxFPSSpinBoxin the config dialog UI.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
kblaschke
approved these changes
May 8, 2026
Member
kblaschke
left a comment
kblaschke
left a comment
There was a problem hiding this comment.
Looks a sensible thing to do!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #7
Summary
The
maxFPSSpinBoxin the config dialog had no explicitmaximumproperty, defaulting to Qt'sQSpinBoxdefault of 99. Users with high-refresh displays (120/144/240 Hz) could set FPS > 99 inconfig.inp, but the UI clamped it back to 99 on save.Change
Added
<maximum>999</maximum>to the spinbox.Test plan