Skip to content

Fix #3: suppress status tips from playlist dock when floating #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
struktured wants to merge 1 commit into
base: master
Choose a base branch
from
+15 −1
Draft

Fix #3: suppress status tips from playlist dock when floating #18

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion src/common/qprojectm_mainwindow.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,13 @@ m_QPlaylistFileDialog( new QPlaylistFileDialog ( this ))
setCentralWidget ( m_QProjectMWidget );
m_QProjectMWidget->installEventFilter(this);

// When the playlist dock is floating on a separate screen, hover events
// would otherwise propagate status tips to the main window's status bar
// (issue #3). Filter them at the dock so the info doesn't appear on the
// wrong screen.
ui->presetPlayListDockWidget->installEventFilter(this);
ui->tableView->installEventFilter(this);

m_timer->start ( 0 );

createActions();
Expand Down Expand Up @@ -1407,7 +1414,14 @@ void QProjectM_MainWindow::handleFailedPresetSwitch(const QString & filename, co

bool QProjectM_MainWindow::eventFilter(QObject *obj, QEvent *event)
{
Q_UNUSED(obj);
// Suppress status tips originating from the playlist when the dock is
// floating on a different screen, so they don't appear on the main
// window's status bar (issue #3).
if (event->type() == QEvent::StatusTip
&& ui->presetPlayListDockWidget->isFloating()
&& (obj == ui->presetPlayListDockWidget || obj == ui->tableView)) {
return true;
}

if (event->type() == QEvent::MouseButtonDblClick && ((QMouseEvent*)event)->button() == Qt::LeftButton) {
this->setWindowState ( this->windowState() ^ Qt::WindowFullScreen );
Expand Down