nit fixes

Author: mbaetgen-wup

src/libprojectM/Renderer/PlatformGLResolver.cpp

@@ -187,11 +187,11 @@ void GLResolver::ResolveProviderFunctions()
     }
 
     {
-        char buf[256];
-        std::snprintf(buf, sizeof(buf), "[GLResolver] Library handles: egl=%p gl=%p",
+        std::array<char, 256> buf{};
+        std::snprintf(buf.data(), buf.size(), "[GLResolver] Library handles: egl=%p gl=%p",
             reinterpret_cast<void*>(m_eglLib.Handle()),
             reinterpret_cast<void*>(m_glLib.Handle()));
-        LOG_DEBUG(buf);
+        LOG_DEBUG(std::string(buf.data()));
     }
 
 }
@@ -211,28 +211,28 @@ void GLResolver::DetectBackend()
 
     if (usingEgl)
     {
-        LOG_DEBUG("[GLResolver] current context: EGL");
+        LOG_DEBUG("[GLResolver] Current context: EGL");
         m_backend = Backend::EglGles;
         return;
     }
 
 #ifndef _WIN32
     if (usingGlx)
     {
-        LOG_DEBUG("[GLResolver] current context: GLX");
+        LOG_DEBUG("[GLResolver] Current context: GLX");
         m_backend = Backend::GlxGl;
         return;
     }
 #else
     if (usingWgl)
     {
-        LOG_DEBUG("[GLResolver] current context: WGL");
+        LOG_DEBUG("[GLResolver] Current context: WGL");
         m_backend = Backend::WglGl;
         return;
     }
 #endif
 
-    LOG_DEBUG("[GLResolver] current context: (unknown, will try generic loader)");
+    LOG_DEBUG("[GLResolver] Current context: (unknown, will try generic loader)");
     m_backend = Backend::None;
 }
 

src/libprojectM/Renderer/PlatformGLResolver.hpp

@@ -26,22 +26,22 @@ enum class Backend : std::uint8_t
     /**
      * Detected EGL backend (GL build), or GLES backend (ENABLE_GLES=ON build).
      */
-    EglGles,
+    EglGles = 1,
 
     /**
      * Detected GLX backend (GL build only).
      */
-    GlxGl,
+    GlxGl = 2,
 
     /**
      * Detected WGL backend (GL build only).
      */
-    WglGl,
+    WglGl = 3,
 
     /**
      * User resolver is used, no backend detection.
      */
-    UserResolver
+    UserResolver = 4
 };
 
 /**
@@ -142,11 +142,11 @@ class GLResolver
     bool m_loaded{false};                         //!< True if the resolver is initialized.
     Backend m_backend{ Backend::None };           //!< Detected GL backend.
 
-    UserResolver m_userResolver{nullptr};         //!< User provided function resolver.
+    UserResolver m_userResolver{nullptr};         //!< User provided function resolver. Optional, may be null.
     void* m_userData{nullptr};                    //!< User data to pass to user provided function resolver.
 
-    DynamicLibrary m_eglLib;                      //!< EGL library handle. Optional, may not be assigned.
-    DynamicLibrary m_glLib;                       //!< Detected GL backend. Optional, may not be assigned.
+    DynamicLibrary m_eglLib;                      //!< EGL library handle. Optional, may be null.
+    DynamicLibrary m_glLib;                       //!< GL library handle. Optional, may be null.
 
     GetProcFunc m_eglGetProcAddress{nullptr};     //!< Function pointer to EGL proc resolver function.
     GetProcFunc m_glxGetProcAddress{nullptr};     //!< Function pointer to GLX proc resolver function.