Fix texture size and sprites#931
Merged
kblaschke merged 2 commits intoNov 13, 2025
Merged
Conversation
kblaschke
requested review from
blaquewithaq,
dpw13,
mbaetgen-wup and
revmischa
The new combined function no longer returns the image size, so we need to load the image ourselves, store the size and then pass the buffer to SOIL_create_OGL_texture().
kblaschke
force-pushed
the
fix-texture-size-and-sprites
branch
from
5f8a0e7 to
5158ecb
Compare
mbaetgen-wup
approved these changes
Nov 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed getting the proper size form textures via SOIL2 as they've changed their loading function. Also added the proper primitive type for rendering Milkdrop user sprites.
Resolves #928