Skip to content

[v4.1.x] Fix static library linking issue and update projectm-eval to latest commit#991

Merged
kblaschke merged 2 commits intoprojectM-visualizer:v4.1.xfrom
kblaschke:v4.1.x-fix-lib-issue-and-update-evallib
Apr 24, 2026
Merged

[v4.1.x] Fix static library linking issue and update projectm-eval to latest commit#991
kblaschke merged 2 commits intoprojectM-visualizer:v4.1.xfrom
kblaschke:v4.1.x-fix-lib-issue-and-update-evallib

Conversation

@kblaschke
Copy link
Copy Markdown
Member

Just two small fixes for the next patch release:

  • Properly propagate static linking flag to export headers when building static libraries. The playlist library tried to import shared symbols (Windows/MinGW32), and thus cause linker errors.
  • Updated projectm-eval submodule to the latest upstream commit.

Otherwise, downstream targets/libraries such as the playlist library may try to import shared library symbols instead.
@kblaschke kblaschke added this to the 4.1.7 milestone Apr 21, 2026
@kblaschke kblaschke self-assigned this Apr 21, 2026
@kblaschke kblaschke added the bug The issue is (potentially) a bug. label Apr 21, 2026
@OfficialIncubo
Copy link
Copy Markdown
Contributor

OfficialIncubo commented Apr 21, 2026

Well. There's a fail.

Edit:

Downloading https://github.com/microsoft/vcpkg-tool/releases/download/2026-04-08/vcpkg.exe -> D:\a\projectm\projectm\vcpkg\vcpkg.exe...While calling Windows API function WinHttpReceiveResponse got error 0x00002EE2:
The operation timed out


D:\a\projectm\projectm\vcpkg\scripts\bootstrap.ps1 : Downloading vcpkg.exe failed. Please check your internet 
connection, or consider downloading a recent vcpkg.exe from https://github.com/microsoft/vcpkg-tool with a browser.
At line:1 char:4
+ & {& "D:\a\projectm\projectm\vcpkg\scripts\bootstrap.ps1" }
+    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : NotSpecified: (:) [Write-Error], WriteErrorException
    + FullyQualifiedErrorId : Microsoft.PowerShell.Commands.WriteErrorException,bootstrap.ps1
 
ScriptHalted
At D:\a\projectm\projectm\vcpkg\scripts\bootstrap.ps1:63 char:5
+     throw
+     ~~~~~
    + CategoryInfo          : OperationStopped: (:) [], RuntimeException
    + FullyQualifiedErrorId : ScriptHalted

I don't know what it caused. But it's likely an internet timeout or no connection. Can you please re-run the tests?

@kblaschke
Copy link
Copy Markdown
Member Author

Well. There's a fail.
I don't know what it caused. But it's likely an internet timeout or no connection. Can you please re-run the tests?

Intermittent failures due to network/server issues, yea. Frequently happens with vcpkg and homebrew, restarting the failed builds mostly fixes it (except for longer outages or toolchain issues).

@kblaschke kblaschke merged commit 62db9b6 into projectM-visualizer:v4.1.x Apr 24, 2026
52 of 53 checks passed
@github-project-automation github-project-automation Bot moved this from In Review to Done in libprojectM Release 4.1 Apr 24, 2026
@kblaschke kblaschke deleted the v4.1.x-fix-lib-issue-and-update-evallib branch April 24, 2026 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug The issue is (potentially) a bug.

Projects

Development

Successfully merging this pull request may close these issues.

3 participants