Strip type attribute from HTML in elements formatted with EAD render. Fixes #1604

Author: seanaery

app/helpers/arclight/ead_format_helpers.rb

@@ -65,6 +65,8 @@ def wrap_in_paragraph(value)
     end
 
     def format_render_attributes(node) # rubocop:disable Metrics/MethodLength, Metrics/AbcSize, Metrics/CyclomaticComplexity
+      node.remove_attribute('type')
+
       case node.attr('render')
       when 'altrender'
         node.name = 'span'

spec/helpers/arclight/ead_format_helpers_spec.rb

@@ -121,6 +121,13 @@
         content = helper.render_html_tags(value: ['The <emph render="underline">Mona Lisa</emph> hangs in the Louvre.'])
         expect(content).to eq 'The <span class="text-underline">Mona Lisa</span> hangs in the Louvre.'
       end
+
+      it 'strips out the xlink:type attribute' do
+        content = helper.render_html_tags(value: ['He acted as photo editor for the student daily newspaper, <title
+          xlink:type="simple" render="italic">The Chronicle</title>.'])
+        expect(content).to eq_ignoring_whitespace \
+          'He acted as photo editor for the student daily newspaper, <em>The Chronicle</em>.'
+      end
     end
 
     describe 'links' do