build qperf from source, use older version for compatibility with kernels without ipv6#18
Closed
lwr20 wants to merge 1 commit into
Closed
build qperf from source, use older version for compatibility with kernels without ipv6#18lwr20 wants to merge 1 commit into
lwr20 wants to merge 1 commit into
Conversation
lwr20
force-pushed
the
lwr-build-patch-qperf
branch
from
0c6c923 to
b9041b6
Compare
lwr20
force-pushed
the
lwr-build-patch-qperf
branch
3 times, most recently
from
985c550 to
f32f6df
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR addresses a bug where qperf fails to run on systems with IPv6 disabled in the kernel by switching from installing qperf via Alpine packages to building from source with a necessary patch applied.
- Replaces package installation with multi-stage Docker build to compile qperf from source
- Uses qperf version 0.4.10 which includes the IPv6 fix
- Adds build dependencies and compilation steps in a separate build stage
lwr20
force-pushed
the
lwr-build-patch-qperf
branch
from
f32f6df to
4e5f933
Compare
lwr20
force-pushed
the
lwr-build-patch-qperf
branch
from
4e5f933 to
6d6899a
Compare
lwr20
changed the title
Member
Author
|
Closing in favour of #20 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://access.redhat.com/solutions/5353011 and linux-rdma/qperf#25 indicate that qperf cannot run in an environment where ipv6 is disabled in the kernel by command line, causing it to error:
linux-rdma/qperf#25 goes on to propose a fix for this. But the fix does not work. Instead, we can roll back the version of qperf to before the commit which added IPv6 support. 0.4.11 requires ipv6, 0.4.10 does not support ipv6.
This PR replaces the qperf install from the alpine packages with building from source code at the pre-ipv6 version tag.