fix: return early after error in impersonateHandler#1043
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds a missing return after error handling in impersonateHandler to prevent execution from continuing after an error response has been written.
Changes:
- Add explicit
returnstatement after handling an error inimpersonateHandler.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
When the user or group lookup fails, the handler was logging/responding the error but then falling through to the impersonation logic. Adding an early return prevents the request from continuing with an empty or invalid identity. Signed-off-by: Cyril Jouve <jv.cyril@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the user or group lookup fails, the handler was logging/responding the error but then falling through to the impersonation logic. Adding an early return prevents the request from continuing with an empty or invalid identity.