fix: consider capsuleconfiguration status users#1046
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates Capsule-Proxy’s CapsuleConfiguration reconciliation to use the authoritative status.users list (instead of spec.users) when building the in-memory user/group sets, and aligns module dependencies accordingly.
Changes:
- Switch CapsuleConfiguration reconciliation to read users/groups from
capsuleConfig.Status.Users. - Bump
github.com/projectcapsule/capsuledependency (and related indirect deps) to support/align with the updated API shape. - Add Makefile targets intended to publish/deploy “enterprise” and “prerelease” artifacts.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
internal/controllers/capsule_configuration.go |
Reads users/groups from CapsuleConfiguration.status.users when populating the cached sets. |
go.mod |
Updates Go/toolchain patch version and bumps Capsule + indirect dependencies. |
go.sum |
Records checksum updates for bumped dependencies. |
Makefile |
Adds enterprise/prerelease publish + deploy helper targets (with issues in the printed Helm flags). |
.golangci.yml |
Adjusts enabled linters (removes gomodguard_v2 from the explicit enable list). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
e7221aa to
fa960d2
Compare
Signed-off-by: Oliver Baehler <oliver@sudo-i.net>
Signed-off-by: Oliver Baehler <oliver@sudo-i.net>
fa960d2 to
91fc58b
Compare
prometherion
approved these changes
Jun 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.