feat(chart): add service properties for gangplank #1050
Merged
oliverbaehler merged 2 commits intoJun 9, 2026
Conversation
Signed-off-by: Oliver Baehler <oliver@sudo-i.net>
Signed-off-by: Oliver Baehler <oliver@sudo-i.net>
There was a problem hiding this comment.
Pull request overview
This PR extends the Helm chart’s Gangplank configuration to allow customizing the Gangplank Service’s metadata and ports, aligning it more closely with the chart’s main Service configurability.
Changes:
- Add Gangplank service values for
annotations,labels, andnodePort, and improveportdescription. - Update the Gangplank Service template to render the new labels/annotations and support
nodePort. - Update the values JSON schema and Helm chart README to document the new Gangplank service options.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| charts/capsule-proxy/values.yaml | Adds Gangplank service config knobs (port/nodePort/labels/annotations) and inline docs. |
| charts/capsule-proxy/values.schema.json | Extends Gangplank service schema with the new fields and descriptions. |
| charts/capsule-proxy/templates/gangplank/service.yaml | Renders the new service metadata fields and supports NodePort behavior. |
| charts/capsule-proxy/README.md | Documents the new Gangplank service values in the parameters table. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+721
to
+723
| # Add these labels to have capsule-proxy show up in `kubectl cluster-info` | ||
| # kubernetes.io/cluster-service: "true" | ||
| # kubernetes.io/name: "Capsule Proxy" |
prometherion
approved these changes
Jun 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.