fix: correct error handling, panic recovery, and JWT concurrency in proxy handler#1068
Draft
oliverbaehler with Copilot wants to merge 4 commits into
Draft
fix: correct error handling, panic recovery, and JWT concurrency in proxy handler#1068oliverbaehler with Copilot wants to merge 4 commits into
oliverbaehler with Copilot wants to merge 4 commits into
Conversation
Signed-off-by: Oliver Baehler <oliver@sudo-i.net>
…ry, and JWT concurrency
Copilot
AI
changed the title
[WIP] Fix code issues based on review comments
fix: correct error handling, panic recovery, and JWT concurrency in proxy handler
Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #1066 introduced several handler fixes but left auth errors mis-classified as 500s, swallowed
http.ErrAbortHandler, returned plain-text panic responses, and introduced a data race on the JWT token cache.Error handling:
*req.ErrUnauthorized→ 403 not 500ResolveUserAndGroupsreturns*req.ErrUnauthorizedfor missing/invalid auth headers. Four call sites (authorizationMiddleware,registerModuleshandler,CheckUserInIgnoredGroupMiddleware,CheckUserInCapsuleGroupMiddleware) were routing all errors throughHandleError(500). Now they mirrorimpersonateHandler:Panic recovery (
recoveryMiddleware)http.ErrAbortHandlerwas swallowed (return); must be re-panicked sonet/httpcan abort the connection correctly.http.Error; now usesserver.HandleErrorfor a consistent Kubernetes-style JSONmetav1.Statusbody.JWT token cache: data race
invalidatedToken(sets.Set[string]) is captured by the middleware closure and mutated concurrently across requests. Fixed with async.RWMutex— reads underRLock, the invalidation write underLock.errors/panic.gow.WriteHeaderwas hardcodinghttp.StatusForbidden/http.StatusInternalServerErrorrather than reading from themetav1.Status.Codefield already set on the struct. Both handlers now usew.WriteHeader(int(status.Code)).