feat: add e2e-minishift Makefile target and workflow job#1892
Closed
feat: add e2e-minishift Makefile target and workflow job#1892
Conversation
Agent-Logs-Url: https://github.com/projectcapsule/capsule/sessions/16188b87-3dc5-4033-960e-5435de48131f Co-authored-by: Svarrogh1337 <16626420+Svarrogh1337@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
Svarrogh1337
April 1, 2026 09:11
View session
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1892 +/- ##
=======================================
Coverage 11.56% 11.56%
=======================================
Files 248 248
Lines 11405 11405
=======================================
Hits 1319 1319
Misses 10041 10041
Partials 45 45 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Hristo Hristov <me@hhristov.info>
Signed-off-by: Hristo Hristov <me@hhristov.info>
Signed-off-by: Hristo Hristov <me@hhristov.info>
Signed-off-by: Hristo Hristov <me@hhristov.info>
Signed-off-by: Hristo Hristov <me@hhristov.info>
Signed-off-by: Hristo Hristov <me@hhristov.info>
Signed-off-by: Hristo Hristov <me@hhristov.info>
Signed-off-by: Hristo Hristov <me@hhristov.info>
Signed-off-by: Hristo Hristov <me@hhristov.info>
Signed-off-by: Hristo Hristov <me@hhristov.info>
Signed-off-by: Hristo Hristov <me@hhristov.info>
Signed-off-by: Hristo Hristov <me@hhristov.info>
Signed-off-by: Hristo Hristov <me@hhristov.info>
Signed-off-by: Hristo Hristov <me@hhristov.info>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Running
make e2eassumes a KinD cluster; there was no path to run the e2e suite against a Minishift/OpenShift cluster.Makefile
e2e-minishift: entry-point that runse2e-install-minishift+e2e-exec, no KinD cluster lifecycle.e2e-install-minishift: likee2e-installbut drops thekind loadstep — the image lands directly in minishift's Docker daemon (viaeval $(minishift docker-env)before invocation), sopullPolicy: Neverstill works.Workflow (
.github/workflows/e2e.yml)New
e2e-minishiftjob:--memory 8192 --cpus 4 --disk-size 40g$GITHUB_ENVsokobuilds target the cluster node, and appendsocto$GITHUB_PATHmake e2e-minishift