Skip to content

feat: add e2e-minishift Makefile target and workflow job#1892

Closed
Copilot wants to merge 15 commits intomainfrom
copilot/run-e2e-on-minishift
Closed

feat: add e2e-minishift Makefile target and workflow job#1892
Copilot wants to merge 15 commits intomainfrom
copilot/run-e2e-on-minishift

Conversation

Copy link
Copy Markdown

Copilot AI commented Apr 1, 2026

Running make e2e assumes a KinD cluster; there was no path to run the e2e suite against a Minishift/OpenShift cluster.

Makefile

  • e2e-minishift: entry-point that runs e2e-install-minishift + e2e-exec, no KinD cluster lifecycle.
  • e2e-install-minishift: like e2e-install but drops the kind load step — the image lands directly in minishift's Docker daemon (via eval $(minishift docker-env) before invocation), so pullPolicy: Never still works.
# eval $(minishift docker-env)
# eval $(minishift oc-env)
make e2e-minishift

Workflow (.github/workflows/e2e.yml)

New e2e-minishift job:

  • Enables KVM via udev rule (required for minishift's VM driver)
  • Downloads and installs minishift v1.34.3
  • Starts minishift with --memory 8192 --cpus 4 --disk-size 40g
  • Exports minishift's Docker daemon env vars into $GITHUB_ENV so ko builds target the cluster node, and appends oc to $GITHUB_PATH
  • Runs make e2e-minishift

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 1, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 11.56%. Comparing base (e1ec9de) to head (b53bb57).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1892   +/-   ##
=======================================
  Coverage   11.56%   11.56%           
=======================================
  Files         248      248           
  Lines       11405    11405           
=======================================
  Hits         1319     1319           
  Misses      10041    10041           
  Partials       45       45           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: Hristo Hristov <me@hhristov.info>
Signed-off-by: Hristo Hristov <me@hhristov.info>
Signed-off-by: Hristo Hristov <me@hhristov.info>
Signed-off-by: Hristo Hristov <me@hhristov.info>
Signed-off-by: Hristo Hristov <me@hhristov.info>
Signed-off-by: Hristo Hristov <me@hhristov.info>
Signed-off-by: Hristo Hristov <me@hhristov.info>
Signed-off-by: Hristo Hristov <me@hhristov.info>
Signed-off-by: Hristo Hristov <me@hhristov.info>
Signed-off-by: Hristo Hristov <me@hhristov.info>
Signed-off-by: Hristo Hristov <me@hhristov.info>
Signed-off-by: Hristo Hristov <me@hhristov.info>
Signed-off-by: Hristo Hristov <me@hhristov.info>
Signed-off-by: Hristo Hristov <me@hhristov.info>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants