Skip to content
This repository was archived by the owner on Nov 11, 2024. It is now read-only.

Adding vendor command support for querying driver & firmware version#57

Open
nandini123-tech wants to merge 1 commit into
projectceladon:celadon/r/mr0/stablefrom
nandini123-tech:stable_r_rm0
Open

Adding vendor command support for querying driver & firmware version#57
nandini123-tech wants to merge 1 commit into
projectceladon:celadon/r/mr0/stablefrom
nandini123-tech:stable_r_rm0

Conversation

@nandini123-tech
Copy link
Copy Markdown

Adding vendor command support for querying driver & firmware version

Tracked-On: OAM-99914
Signed-off-by: N V NandiniX nandinix.n.v@intel.com

Tracked-On: OAM-99914
Signed-off-by: N V NandiniX <nandinix.n.v@intel.com>
sysopenci pushed a commit that referenced this pull request Dec 8, 2022
…) to avoid crash

[ Upstream commit 68b99e94a4a2db6ba9b31fe0485e057b9354a640 ]

When CPU 0 is offline and intel_powerclamp is used to inject
idle, it generates kernel BUG:

BUG: using smp_processor_id() in preemptible [00000000] code: bash/15687
caller is debug_smp_processor_id+0x17/0x20
CPU: 4 PID: 15687 Comm: bash Not tainted 5.19.0-rc7+ #57
Call Trace:
<TASK>
dump_stack_lvl+0x49/0x63
dump_stack+0x10/0x16
check_preemption_disabled+0xdd/0xe0
debug_smp_processor_id+0x17/0x20
powerclamp_set_cur_state+0x7f/0xf9 [intel_powerclamp]
...
...

Here CPU 0 is the control CPU by default and changed to the current CPU,
if CPU 0 offlined. This check has to be performed under cpus_read_lock(),
hence the above warning.

Use get_cpu() instead of smp_processor_id() to avoid this BUG.

Suggested-by: Chen Yu <yu.c.chen@intel.com>
Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
[ rjw: Subject edits ]
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
@sysopenci sysopenci added the Stale Stale label for inactive open prs label Sep 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Stale Stale label for inactive open prs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants