Skip to content

fix: differentiate HTTP vs HTTPS protocol in interactions#1338

Merged
dogancanbakir merged 1 commit into
devfrom
fix/http-https-protocol-differentiation
Feb 24, 2026
Merged

fix: differentiate HTTP vs HTTPS protocol in interactions#1338
dogancanbakir merged 1 commit into
devfrom
fix/http-https-protocol-differentiation

Conversation

@dogancanbakir

Copy link
Copy Markdown
Member

Summary

  • Check r.TLS != nil to set interaction protocol to "https" when request arrives over TLS, instead of always using "http"
  • Add httpProtocol helper and pass *http.Request to handleInteraction
  • Add unit test covering both plaintext and TLS cases

Fixes #1290

@neo-by-projectdiscovery-dev

neo-by-projectdiscovery-dev Bot commented Feb 24, 2026

Copy link
Copy Markdown

Neo Security Audit

No security issues found

Comment @neo help for available commands. · Open in Neo

@coderabbitai

coderabbitai Bot commented Feb 24, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/http-https-protocol-differentiation

Comment @coderabbitai help to get the list of available commands and usage tips.

@dogancanbakir dogancanbakir linked an issue Feb 24, 2026 that may be closed by this pull request
@dogancanbakir
dogancanbakir merged commit a7751f3 into dev Feb 24, 2026
10 checks passed
@dogancanbakir
dogancanbakir deleted the fix/http-https-protocol-differentiation branch February 24, 2026 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Differentiate HTTP vs HTTPS

2 participants