fix: populate GetBody to support 307/308 redirects#494
Closed
dwisiswant0 wants to merge 3 commits into
Closed
Conversation
Signed-off-by: Dwi Siswanto <git@dw1.io>
When sending POST requests with a non-empty body that trigger 307/308 redirects, the redirects fail because the underlying `http.Request.GetBody` is nil by default. This patch populates `GetBody` using the existing reusable body reader, allowing the `net/http` client to rewind and replay the body. Fixes #493. Signed-off-by: Dwi Siswanto <git@dw1.io>
Signed-off-by: Dwi Siswanto <git@dw1.io>
Member
Author
|
Superseded by #496 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When sending POST requests with a non-empty body
that trigger 307/308 redirects, the redirects fail
because the underlying
http.Request.GetBodyisnil by default.
This patch populates
GetBodyusing the existingreusable body reader, allowing the
net/httpclient to rewind and replay the body.
Fixes #493.
Proof
patch:
main: