lora-sx126x: Enable all IRQ Mask bits unconditionally.

Expands _IRQ_CRC_ERR fix in the parent commit by always enabling
all the Irq Mask bits that the driver may want to read back later.

Signed-off-by: Angus Gratton <angus@redyak.com.au>

Author: projectgus

micropython/lora/lora-sx126x/lora/sx126x.py

@@ -224,21 +224,24 @@ def __init__(
 
         # If DIO1 is set, mask in just the IRQs that the driver may need to be
         # interrupted by. This is important because otherwise an unrelated IRQ
-        # can trigger the ISR and may not be reset by the driver, leaving DIO1 high.
-        #
-        # If DIO1 is not set, all IRQs can stay masked which is the power-on state.
+        # can trigger the ISR and may not be reset by the driver, leaving DIO1
+        # high.
         if dio1:
-            # Note: we set both Irq mask and DIO1 mask to the same value, which is redundant
-            # (one could be 0xFFFF) but may save a few bytes of bytecode.
-            self._cmd(
-                ">BHHHH",
-                _CMD_CFG_DIO_IRQ,
-                (_IRQ_RX_DONE | _IRQ_TX_DONE | _IRQ_TIMEOUT | _IRQ_CRC_ERR),  # IRQ mask
-                (_IRQ_RX_DONE | _IRQ_TX_DONE | _IRQ_TIMEOUT),  # DIO1 mask
-                0x0,  # DIO2Mask, not used
-                0x0,  # DIO3Mask, not used
-            )
-            dio1.irq(self._radio_isr, Pin.IRQ_RISING)
+            dio1_mask = _IRQ_RX_DONE | _IRQ_TX_DONE | _IRQ_TIMEOUT
+        else:
+            dio1_mask = 0
+
+        self._cmd(
+            ">BHHHH",
+            _CMD_CFG_DIO_IRQ,
+            # The Irq Mask byte needs to be set so that _CMD_GET_IRQ_STATUS returns all
+            # relevant flags that driver might check
+            _IRQ_TX_DONE | _IRQ_DRIVER_RX_MASK,
+            dio1_mask,  # DIO1Mask
+            0x0,  # DIO2Mask, not used
+            0x0,  # DIO3Mask, not used
+        )
+        dio1.irq(self._radio_isr, Pin.IRQ_RISING)
 
         self._clear_irq()
 

micropython/lora/lora-sx126x/manifest.py

@@ -1,3 +1,3 @@
-metadata(version="0.1.5")
+metadata(version="0.1.6")
 require("lora")
 package("lora")