Skip to content

Commit 4aa7a32

Browse files
committed
(bug) In DryRun do not increase consecutive failures
In DryRun mode we always return an error, so do not increase consecutive failures
1 parent ade1a5c commit 4aa7a32

1 file changed

Lines changed: 8 additions & 5 deletions

File tree

pkg/scope/clustersummary.go

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -108,11 +108,14 @@ func (s *ClusterSummaryScope) SetFeatureStatus(featureID configv1beta1.FeatureID
108108
if s.ClusterSummary.Status.FeatureSummaries[i].FeatureID == featureID {
109109
s.ClusterSummary.Status.FeatureSummaries[i].Status = status
110110
s.ClusterSummary.Status.FeatureSummaries[i].Hash = hash
111-
if failed != nil {
112-
if *failed {
113-
s.ClusterSummary.Status.FeatureSummaries[i].ConsecutiveFailures++
114-
} else {
115-
s.ClusterSummary.Status.FeatureSummaries[i].ConsecutiveFailures = 0
111+
if s.ClusterSummary.Spec.ClusterProfileSpec.SyncMode != configv1beta1.SyncModeDryRun {
112+
// In DryRun mode we always get an error back. Do not increase ConsecutiveFailures
113+
if failed != nil {
114+
if *failed {
115+
s.ClusterSummary.Status.FeatureSummaries[i].ConsecutiveFailures++
116+
} else {
117+
s.ClusterSummary.Status.FeatureSummaries[i].ConsecutiveFailures = 0
118+
}
116119
}
117120
}
118121
return

0 commit comments

Comments
 (0)