Optionally set COMMODORE_CATALOG_COMPILE_PROCESSES based on cluster's CPU limit#42
Merged
Conversation
simu
force-pushed
the
feat/more-resource-tuning
branch
from
May 28, 2026 14:45
d110653 to
c29fa84
Compare
simu
force-pushed
the
feat/more-resource-tuning
branch
from
May 28, 2026 14:46
c29fa84 to
fda7b30
Compare
simu
changed the title
COMMODORE_CATALOG_COMPILE_PROCESSES based on cluster's CPU limit
simu
force-pushed
the
feat/more-resource-tuning
branch
from
May 28, 2026 14:56
fda7b30 to
667e25c
Compare
simu
marked this pull request as ready for review
May 28, 2026 15:04
simu
force-pushed
the
feat/more-resource-tuning
branch
from
May 28, 2026 15:19
667e25c to
bf3ee9a
Compare
simu
force-pushed
the
feat/more-resource-tuning
branch
3 times, most recently
from
May 29, 2026 07:40
94eea44 to
8229cf2
Compare
bastjan
approved these changes
May 29, 2026
…'s CPU limit Users can opt-in to setting each CI job's environment variable `COMMODORE_CATALOG_COMPILE_PROCESSES` based on the cluster's CPU limit by setting the environment variable `COMMODORE_PROCESSES_FROM_CPU_LIMIT` to a non-empty value in their GitLab CI config. For CI configurations that opt-in to this feature, we compute the Commodore process count based on the cluster's CPU limit by rounding down to the next nearest integer, clamped at 1. Currently, the CPU limit parser supports unsuffixed CPU limits and milli-CPU CPU limits and will raise an error for other CPU limit configurations. For CI configurations that don't opt-in to this feature, `COMMODORE_CATALOG_COMPILE_PROCESSES` is set to `0` which allows Commodore to auto-detect the number of worker processes to use, preserving the Commodore v1.33.1 and older behavior.
simu
force-pushed
the
feat/more-resource-tuning
branch
from
May 29, 2026 08:06
8229cf2 to
c4a201d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Users can opt-in to setting each CI job's environment variable
COMMODORE_CATALOG_COMPILE_PROCESSESbased on the cluster's CPU limit by setting the environment variableCOMMODORE_PROCESSES_FROM_CPU_LIMITto a non-empty value in their GitLab CI config.For CI configurations that opt-in to this feature, we compute the Commodore process count based on the cluster's CPU limit by rounding down to the next nearest integer, clamped at 1.
The CPU limit parser supports all supported K8s quantity values (cf. https://kubernetes.io/docs/reference/kubernetes-api/definitions/quantity-resource/)
For CI configurations that don't opt-in to this feature,
COMMODORE_CATALOG_COMPILE_PROCESSESis set to0which allows Commodore to auto-detect the number of worker processes to use, preserving the Commodore v1.33.1 and older behavior.Checklist
changelog.
The PR has a meaningful description that sums up the change. It will be
linked in the changelog.
in the correct changelog section:
bug,enhancement,documentation,change,breaking,dependency,internal