Fix permissions for /app/.cache/ in the container image#1178
Merged
Conversation
We now populate `/app/.cache/commodore/tools` with the required external tools, but other tooling (e.g. Helm) also needs to be able to write to `/app/.cache` (and commodore itself needs to be able to write to `/app/.cache/commodore/token`). While refactoring the Dockerfile, we forgot to extend the permission adjustments for `/app` to also cover existing directories in `/app/.cache`. This commit ensures that everything in `/app` has group 0 and that directories `/app/.cache/` and `/app/.cache/commodore` are writable by group 0.
DebakelOrakel
approved these changes
Jul 16, 2025
haasad
approved these changes
Jul 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We now populate
/app/.cache/commodore/toolswith the required external tools, but other tooling (e.g. Helm) also needs to be able to write to/app/.cache(and commodore itself needs to be able to write to/app/.cache/commodore/token). While refactoring the Dockerfile, we forgot to extend the permission adjustments for/appto also cover existing directories in/app/.cache.This commit ensures that everything in
/apphas group 0 and that directories/app/.cache/and/app/.cache/commodoreare writable by group 0.Follow-up to #1174
Checklist
bug,enhancement,documentation,change,breaking,dependency,internalas they show up in the changelog