Revert "Fix missing finalizers in the ArgoCD app"

simu · simu · commit 892e6bf000f2 · 2026-04-22T09:59:24.000+02:00
With projectsyn/component-argocd#287 we shouldn't need to manage the dynamically added ArgoCD finalizers on the ArgoCD app anymore. This reverts commit e676045.
diff --git a/component/app.jsonnet b/component/app.jsonnet
@@ -11,13 +11,5 @@ local appPath =
   if project == 'syn' then 'apps' else 'apps-%s' % project;
 
 {
-  ['%s/backup-k8up' % appPath]: app {
-    metadata+: {
-      finalizers: [
-        'resources-finalizer.argocd.argoproj.io',
-        'post-delete-finalizer.argocd.argoproj.io',
-        'post-delete-finalizer.argocd.argoproj.io/cleanup'
-      ],
-    },
-  },
+  ['%s/backup-k8up' % appPath]: app,
 }
diff --git a/tests/golden/defaults/backup-k8up/apps/backup-k8up.yaml b/tests/golden/defaults/backup-k8up/apps/backup-k8up.yaml
@@ -1,5 +0,0 @@
-metadata:
-  finalizers:
-    - resources-finalizer.argocd.argoproj.io
-    - post-delete-finalizer.argocd.argoproj.io
-    - post-delete-finalizer.argocd.argoproj.io/cleanup

Original file line number	Diff line number	Diff line change
`@@ -11,13 +11,5 @@ local appPath =`
`11`	`11`	`if project == 'syn' then 'apps' else 'apps-%s' % project;`
`12`	`12`
`13`	`13`	`{`
`14`		`- ['%s/backup-k8up' % appPath]: app {`
`15`		`- metadata+: {`
`16`		`- finalizers: [`
`17`		`- 'resources-finalizer.argocd.argoproj.io',`
`18`		`- 'post-delete-finalizer.argocd.argoproj.io',`
`19`		`- 'post-delete-finalizer.argocd.argoproj.io/cleanup'`
`20`		`- ],`
`21`		`- },`
`22`		`- },`
	`14`	`+ ['%s/backup-k8up' % appPath]: app,`
`23`	`15`	`}`