Merge pull request #174 from projectsyn/bug/argocd-app-finalizers

DebakelOrakel · web-flow · commit 9b84d63535f4 · 2026-04-13T13:30:05.000+02:00
Fix missing finalizers in the ArgoCD app
diff --git a/component/app.jsonnet b/component/app.jsonnet
@@ -11,5 +11,13 @@ local appPath =
   if project == 'syn' then 'apps' else 'apps-%s' % project;
 
 {
-  ['%s/backup-k8up' % appPath]: app,
+  ['%s/backup-k8up' % appPath]: app {
+    metadata+: {
+      finalizers: [
+        'resources-finalizer.argocd.argoproj.io',
+        'post-delete-finalizer.argocd.argoproj.io',
+        'post-delete-finalizer.argocd.argoproj.io/cleanup'
+      ],
+    },
+  },
 }
diff --git a/tests/golden/defaults/backup-k8up/apps/backup-k8up.yaml b/tests/golden/defaults/backup-k8up/apps/backup-k8up.yaml
@@ -0,0 +1,5 @@
+metadata:
+  finalizers:
+    - resources-finalizer.argocd.argoproj.io
+    - post-delete-finalizer.argocd.argoproj.io
+    - post-delete-finalizer.argocd.argoproj.io/cleanup

Original file line number	Diff line number	Diff line change
`@@ -11,5 +11,13 @@ local appPath =`
`11`	`11`	`if project == 'syn' then 'apps' else 'apps-%s' % project;`
`12`	`12`
`13`	`13`	`{`
`14`		`- ['%s/backup-k8up' % appPath]: app,`
	`14`	`+ ['%s/backup-k8up' % appPath]: app {`
	`15`	`+ metadata+: {`
	`16`	`+ finalizers: [`
	`17`	`+ 'resources-finalizer.argocd.argoproj.io',`
	`18`	`+ 'post-delete-finalizer.argocd.argoproj.io',`
	`19`	`+ 'post-delete-finalizer.argocd.argoproj.io/cleanup'`
	`20`	`+ ],`
	`21`	`+ },`
	`22`	`+ },`
`15`	`23`	`}`