Merge pull request #71 from projectsyn/feat/support-instances

Support multiple instances

Author: DebakelOrakel

class/defaults.yml

@@ -1,6 +1,10 @@
 parameters:
   fluentbit:
+    =_metadata:
+      multi_instance: true
+
     namespace: syn-fluentbit
+    createNamespace: true
 
     charts:
       fluent-bit:
@@ -16,7 +20,7 @@ parameters:
     annotations:
       fluentbit.io/exclude: "true"
 
-    configMapName: syn-fluentbit-config
+    configMapName: ${_instance}
     config:
       # fluent-bit service config
       service:
@@ -78,6 +82,7 @@ parameters:
     tolerations: []
 
     helm_values:
+      fullnameOverride: ${_instance}
       podAnnotations: ${fluentbit:annotations}
       image:
         repository: ${fluentbit:images:fluent_bit:image}

class/fluentbit.yml

@@ -2,7 +2,7 @@ parameters:
   kapitan:
     dependencies:
       - type: helm
-        output_path: dependencies/fluentbit/helmcharts/fluent-bit-${fluentbit:charts:fluent-bit:version}
+        output_path: ${_base_directory}/helmcharts/fluent-bit-${fluentbit:charts:fluent-bit:version}
         source: ${fluentbit:charts:fluent-bit:source}
         version: ${fluentbit:charts:fluent-bit:version}
         chart_name: fluent-bit
@@ -14,19 +14,18 @@ parameters:
       - input_paths:
           - fluentbit/component/main.jsonnet
         input_type: jsonnet
-        output_path: fluentbit/
-      - output_path: fluentbit/01_fluentbit_helmchart
+        output_path: fluentbit/${_instance}/
+      - input_paths:
+          - ${_base_directory}/helmcharts/fluent-bit-${fluentbit:charts:fluent-bit:version}
         input_type: helm
-        output_type: yaml
-        input_paths:
-          - fluentbit/helmcharts/fluent-bit-${fluentbit:charts:fluent-bit:version}
+        output_path: fluentbit/${_instance}/01_fluentbit_helmchart
         helm_values: ${fluentbit:helm_values}
         helm_params:
+          name: ${_instance}
           namespace: ${fluentbit:namespace}
-          name_template: fluent-bit
   commodore:
     postprocess:
       filters:
         - type: jsonnet
-          path: fluentbit/01_fluentbit_helmchart/fluent-bit/templates
+          path: fluentbit/${_instance}/01_fluentbit_helmchart/fluent-bit/templates
           filter: postprocess/patch_helm_output.jsonnet

component/app.jsonnet

@@ -3,8 +3,14 @@ local inv = kap.inventory();
 local params = inv.parameters.fluentbit;
 local argocd = import 'lib/argocd.libjsonnet';
 
-local app = argocd.App('fluentbit', params.namespace);
+local app = argocd.App(inv.parameters._instance, params.namespace) {
+  spec+: {
+    source+: {
+      path: 'manifests/fluentbit/' + inv.parameters._instance,
+    },
+  },
+};
 
 {
-  fluentbit: app,
+  [inv.parameters._instance]: app,
 }

component/main.jsonnet

@@ -4,6 +4,7 @@ local kube = import 'lib/kube.libjsonnet';
 local inv = kap.inventory();
 // The hiera parameters for the component
 local params = inv.parameters.fluentbit;
+local instanceName = inv.parameters._instance;
 
 local render_fluentbit_cfg(type, name, cfg) =
   local header = '[%s]' % std.asciiUpper(type);
@@ -148,7 +149,7 @@ local configmap = kube.ConfigMap(params.configMapName) {
     namespace: params.namespace,
     labels+: {
       'app.kubernetes.io/name': 'fluent-bit',
-      'app.kubernetes.io/instance': 'fluent-bit-cluster',
+      'app.kubernetes.io/instance': instanceName,
       'app.kubernetes.io/version':
         std.split(params.images.fluent_bit.tag, '@')[0],
       'app.kubernetes.io/component': 'fluent-bit',
@@ -162,15 +163,15 @@ local configmap = kube.ConfigMap(params.configMapName) {
 };
 
 {
-  '00_namespace': kube.Namespace(params.namespace),
+  [if params.createNamespace then '00_namespace']: kube.Namespace(params.namespace),
   '10_custom_config': configmap,
   [if params.monitoring.enabled then '20_service_monitor']:
     kube._Object('monitoring.coreos.com/v1', 'ServiceMonitor', 'fluent-bit') {
       metadata+: {
         namespace: params.namespace,
         labels+: {
           'app.kubernetes.io/name': 'fluent-bit',
-          'app.kubernetes.io/instance': 'fluent-bit-cluster',
+          'app.kubernetes.io/instance': instanceName,
           'app.kubernetes.io/version':
             std.split(params.images.fluent_bit.tag, '@')[0],
           'app.kubernetes.io/component': 'fluent-bit',
@@ -185,7 +186,7 @@ local configmap = kube.ConfigMap(params.configMapName) {
         selector: {
           matchLabels: {
             'app.kubernetes.io/name': 'fluent-bit',
-            'app.kubernetes.io/instance': 'fluent-bit',
+            'app.kubernetes.io/instance': instanceName,
           },
         },
       },

docs/modules/ROOT/pages/references/parameters.adoc

@@ -10,6 +10,22 @@ default:: `syn-fluentbit`
 
 The namespace in which to deploy this component.
 
+== `createNamespace`
+
+[horizontal]
+type:: bool
+default:: true
+
+Wether to create the configured namespace or not.
+
+== `configMapName`
+
+[horizontal]
+type:: string
+default:: `${_instance}`
+
+The name of the generated ConfigMap.
+
 == `config`
 
 [horizontal]

tests/golden/defaults/fluentbit/apps/fluentbit.yaml

@@ -0,0 +1,3 @@
+spec:
+  source:
+    path: manifests/fluentbit/fluentbit

…ts/fluentbit/fluentbit/00_namespace.yaml …it/fluentbit/fluentbit/00_namespace.yamltests/golden/defaults/fluentbit/fluentbit/00_namespace.yaml renamed to tests/golden/defaults/fluentbit/fluentbit/fluentbit/00_namespace.yaml tests/golden/defaults/fluentbit/fluentbit/00_namespace.yaml renamed to tests/golden/defaults/fluentbit/fluentbit/fluentbit/00_namespace.yaml

@@ -2,12 +2,12 @@ apiVersion: rbac.authorization.k8s.io/v1
 kind: ClusterRole
 metadata:
   labels:
-    app.kubernetes.io/instance: fluent-bit
+    app.kubernetes.io/instance: fluentbit
     app.kubernetes.io/managed-by: Helm
     app.kubernetes.io/name: fluent-bit
     app.kubernetes.io/version: 3.1.4
     helm.sh/chart: fluent-bit-0.47.5
-  name: fluent-bit
+  name: fluentbit
 rules:
   - apiGroups:
       - ''

…rt/fluent-bit/templates/clusterrole.yaml …rt/fluent-bit/templates/clusterrole.yamltests/golden/defaults/fluentbit/fluentbit/01_fluentbit_helmchart/fluent-bit/templates/clusterrole.yaml renamed to tests/golden/defaults/fluentbit/fluentbit/fluentbit/01_fluentbit_helmchart/fluent-bit/templates/clusterrole.yaml tests/golden/defaults/fluentbit/fluentbit/01_fluentbit_helmchart/fluent-bit/templates/clusterrole.yaml renamed to tests/golden/defaults/fluentbit/fluentbit/fluentbit/01_fluentbit_helmchart/fluent-bit/templates/clusterrole.yaml

@@ -2,17 +2,17 @@ apiVersion: rbac.authorization.k8s.io/v1
 kind: ClusterRoleBinding
 metadata:
   labels:
-    app.kubernetes.io/instance: fluent-bit
+    app.kubernetes.io/instance: fluentbit
     app.kubernetes.io/managed-by: Helm
     app.kubernetes.io/name: fluent-bit
     app.kubernetes.io/version: 3.1.4
     helm.sh/chart: fluent-bit-0.47.5
-  name: fluent-bit
+  name: fluentbit
 roleRef:
   apiGroup: rbac.authorization.k8s.io
   kind: ClusterRole
-  name: fluent-bit
+  name: fluentbit
 subjects:
   - kind: ServiceAccount
-    name: fluent-bit
+    name: fluentbit
     namespace: syn-fluentbit

…nt-bit/templates/clusterrolebinding.yaml …nt-bit/templates/clusterrolebinding.yamltests/golden/defaults/fluentbit/fluentbit/01_fluentbit_helmchart/fluent-bit/templates/clusterrolebinding.yaml renamed to tests/golden/defaults/fluentbit/fluentbit/fluentbit/01_fluentbit_helmchart/fluent-bit/templates/clusterrolebinding.yaml tests/golden/defaults/fluentbit/fluentbit/01_fluentbit_helmchart/fluent-bit/templates/clusterrolebinding.yaml renamed to tests/golden/defaults/fluentbit/fluentbit/fluentbit/01_fluentbit_helmchart/fluent-bit/templates/clusterrolebinding.yaml

@@ -2,17 +2,17 @@ apiVersion: apps/v1
 kind: DaemonSet
 metadata:
   labels:
-    app.kubernetes.io/instance: fluent-bit
+    app.kubernetes.io/instance: fluentbit
     app.kubernetes.io/managed-by: Helm
     app.kubernetes.io/name: fluent-bit
     app.kubernetes.io/version: 3.1.4
     helm.sh/chart: fluent-bit-0.47.5
-  name: fluent-bit
+  name: fluentbit
   namespace: syn-fluentbit
 spec:
   selector:
     matchLabels:
-      app.kubernetes.io/instance: fluent-bit
+      app.kubernetes.io/instance: fluentbit
       app.kubernetes.io/name: fluent-bit
   template:
     metadata:
@@ -21,7 +21,7 @@ spec:
         checksum/syn-config: 06e588437d65a5b9ef0171f6ac0a59e7
         fluentbit.io/exclude: 'true'
       labels:
-        app.kubernetes.io/instance: fluent-bit
+        app.kubernetes.io/instance: fluentbit
         app.kubernetes.io/name: fluent-bit
     spec:
       containers:
@@ -58,10 +58,10 @@ spec:
               readOnly: true
       dnsPolicy: ClusterFirst
       hostNetwork: false
-      serviceAccountName: fluent-bit
+      serviceAccountName: fluentbit
       volumes:
         - configMap:
-            name: syn-fluentbit-config
+            name: fluentbit
           name: config
         - hostPath:
             path: /var/log