Skip to content

Refactor additional config rendering#18

Merged
DebakelOrakel merged 4 commits into
masterfrom
feat/additional-config-rendering
Jun 26, 2026
Merged

Refactor additional config rendering#18
DebakelOrakel merged 4 commits into
masterfrom
feat/additional-config-rendering

Conversation

@DebakelOrakel

@DebakelOrakel DebakelOrakel commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

This PR renders additional parameters for cofiguring the component.

  • Enables monitoring by default
  • Renders Ingress and BasicAuth
  • Handle ZoneAwareReplication only with Rollout-Operator
  • Renders OpenShift specific configuration

Checklist

  • The PR has a meaningful title. It will be used to auto-generate the
    changelog.
    The PR has a meaningful description that sums up the change. It will be
    linked in the changelog.
  • PR contains a single logical change (to build a better changelog).
  • Update the documentation.
  • Categorize the PR by adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog.
  • Link this PR to related issues or PRs.

@DebakelOrakel DebakelOrakel added the enhancement New feature or request label Jun 25, 2026
@DebakelOrakel DebakelOrakel changed the title Feat/additional config rendering Refactor additional config rendering Jun 25, 2026
@DebakelOrakel DebakelOrakel requested a review from a team June 25, 2026 10:12
@DebakelOrakel DebakelOrakel added breaking and removed enhancement New feature or request labels Jun 25, 2026

@simu simu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I assume this will allow us to clean up our own instance config analogous to tests/openshift.yml?

@DebakelOrakel

Copy link
Copy Markdown
Contributor Author

LGTM. I assume this will allow us to clean up our own instance config analogous to tests/openshift.yml?

yes that is the plan, also analog to mimir.

@DebakelOrakel DebakelOrakel merged commit 10c80c2 into master Jun 26, 2026
17 checks passed
@DebakelOrakel DebakelOrakel deleted the feat/additional-config-rendering branch June 26, 2026 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants