Remove default GitRepo Type from specification

Our OpenAPI validation library added support for default values. This
includes a feature/bug that fails the validation if defaults are set for
`merge-patch+json` requests.

We currently define a GitRepo type default of `auto` . This is defined
across all requests and responses. However this is arguably wrong for
patches. When patching a resource we generally don't want to set default
as this will lead to unexpected results (i.e. reverting to the default
if we do not explicitly set it to the current value in the patch)

For this reason (and to fix the validation error) we remove the GitRepo
type default from the specification.

Author: glrf

openapi.yaml

@@ -212,7 +212,6 @@ components:
           type: string
           description: Specifies if a repo should be managed by the git controller. A value of 'unmanaged' means it's not manged by the controller
           example: auto
-          default: auto
         deployKey:
           type: string
           description: SSH public key / deploy key for clusterconfiguration catalog Git repository. This property is managed by Steward.

pkg/api/openapi.go

@@ -66,6 +66,8 @@ func TestCreateTenant(t *testing.T) {
 	assert.Contains(t, tenant.Id, api.TenantIDPrefix)
 	assert.Equal(t, newTenant.DisplayName, tenant.DisplayName)
 	assert.Equal(t, newTenant.GitRepo.Url, tenant.GitRepo.Url)
+	assert.NotNil(t, tenant.GitRepo.Type)
+	assert.Equal(t, "auto", *tenant.GitRepo.Type)
 	assert.Contains(t, *tenant.Annotations, "new")
 	assert.Len(t, *tenant.Annotations, 1)