Parse hex numbers#270
Open
giacomolicari wants to merge 3 commits into
Open
Conversation
5e0b809 to
a030979
Compare
added 3 commits
November 2, 2023 15:18
Signed-off-by: Giacomo Licari <giacomo@gnosis.io>
Signed-off-by: Giacomo Licari <giacomo@gnosis.io>
Signed-off-by: Giacomo Licari <giacomo@gnosis.io>
a030979 to
56f3fef
Compare
|
Hi @giacomolicari, Maybe circleci pass merging BTW thanks for the change. |
|
@giacomolicari the tests are failing in ci because of fmt... solves that... Can you please update this pr with that? |
|
I'd really like this feature as well, hoping for the fix to get pushed soon... |
|
I have a version of this PR thats been rebased on latest master with formatting over at https://github.com/Pacman99/json_exporter/tree/hex-parser. Happy to open a new PR if there is a chance of this feature being merged - commits on that branch are still credited to original author |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the ability for the scraper to convert hex numbers into float64.
Concrete example, if we have a JSON like:
where the key result is an hex representation of an integer, and we want that hex data to be correctly interpreted into a number, we would get it parsed from
0x1d55359to30757721.Also add a Dockerfile that builds the project.