Fix timestamped values#277
Open
ilario wants to merge 3 commits into
Open
Conversation
Signed-off-by: Ilario Gelmetti <iochesonome@gmail.com>
Signed-off-by: Ilario Gelmetti <iochesonome@gmail.com>
Signed-off-by: Ilario Gelmetti <iochesonome@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Running the example from the readme, I didn't get any timestamp in the timestamped example from data.json.
I identified tree small issues, one in the example config.yml, another in the example data.json and another in the util.go's "SanitizeIntValue" function:
epochtimestampin config.yml has to be in lower casePlease check if the Go coding is correct, as I am not experienced with it at all.