add "4096" as healthy BBU code (#164)

avk999 · web-flow · commit 578134874e0b · 2023-06-29T14:43:50.000+02:00
Old PERC controllers (at least PERC H730/740 Mini) with FW 4.270.00-8168 return BBU status 4096. Comparing the output with MegaCLI output it seems that this bit corresponds to "Learning cycle required" indicator. However since controller runs learning cycles by itself there is no reason for alerting.

Signed-off-by: a &lt;andrew.v.kovalev@gmail.com&gt;
diff --git a/storcli.py b/storcli.py
@@ -249,7 +249,7 @@ def handle_megaraid_controller(response):
     if response["Status"]["BBU Status"] != "NA":
         # BBU Status Optimal value is 0 for normal, 8 for charging.
         metrics["bbu_healthy"].labels(controller_index).set(
-            response["Status"]["BBU Status"] in [0, 8]
+            response["Status"]["BBU Status"] in [0, 8, 4096]
         )
 
     metrics["ctrl_degraded"].labels(controller_index).set(

Original file line number	Diff line number	Diff line change
`@@ -249,7 +249,7 @@ def handle_megaraid_controller(response):`
`249`	`249`	`if response["Status"]["BBU Status"] != "NA":`
`250`	`250`	`# BBU Status Optimal value is 0 for normal, 8 for charging.`
`251`	`251`	`metrics["bbu_healthy"].labels(controller_index).set(`
`252`		`- response["Status"]["BBU Status"] in [0, 8]`
	`252`	`+ response["Status"]["BBU Status"] in [0, 8, 4096]`
`253`	`253`	`)`
`254`	`254`
`255`	`255`	`metrics["ctrl_degraded"].labels(controller_index).set(`