Skip to content

Commit 2a367b9

Browse files
committed
histogram: Add a doc comment about when to add a no-op span
See prometheus/client_golang#1127 for details. Signed-off-by: beorn7 <beorn@grafana.com>
1 parent 95a0733 commit 2a367b9

2 files changed

Lines changed: 6 additions & 0 deletions

File tree

go/metrics.pb.go

Lines changed: 3 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

io/prometheus/client/metrics.proto

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -98,6 +98,9 @@ message Histogram {
9898
repeated double negative_count = 11; // Absolute count of each bucket.
9999

100100
// Positive buckets for the native histogram.
101+
// Use a no-op span (offset 0, length 0) for a native histogram without any
102+
// observations yet and with a zero_threshold of 0. Otherwise, it would be
103+
// indistinguishable from a classic histogram.
101104
repeated BucketSpan positive_span = 12;
102105
// Use either "positive_delta" or "positive_count", the former for
103106
// regular histograms with integer counts, the latter for float

0 commit comments

Comments
 (0)