fix: resolve lint/typing issues and add Windows CI coverage

Signed-off-by: MelvinjoseC <165891174+MelvinjoseC@users.noreply.github.com>

Author: MelvinjoseC

.github/workflows/ci.yaml

@@ -108,3 +108,17 @@ jobs:
         run: tox
         env:
           TOXENV: pypy${{ env.PYTHON_VERSION }}
+
+  test_windows:
+    runs-on: windows-latest
+    steps:
+      - uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6.0.1
+      - name: Set up Python
+        uses: actions/setup-python@83679a892e2d95755f2dac6acb0bfd1e9ac5d548 # v6.1.0
+        with:
+          python-version: '3.12'
+      - name: Install dependencies
+        run: pip install tox "virtualenv<20.22.0"
+      - name: Run tests
+        run: python -m tox -e py3.12
+

prometheus_client/values.py

@@ -1,11 +1,11 @@
 import os
 from threading import Lock
+from typing import Callable, List
 import warnings
 
 from .mmap_dict import mmap_key, MmapedDict
 
-
-_multi_process_cleanups = []
+_multi_process_cleanups: List[Callable[[], None]] = []
 
 
 def close_all_multiprocess_files():

tests/test_parser.py

@@ -1,3 +1,4 @@
+import importlib.util
 import math
 import unittest
 
@@ -375,11 +376,7 @@ def collect(self):
         self.assertEqual(text.encode('utf-8'), generate_latest(registry, ALLOWUTF8))
 
 
-try:
-    import pytest_benchmark
-    HAS_BENCHMARK = True
-except ImportError:
-    HAS_BENCHMARK = False
+HAS_BENCHMARK = importlib.util.find_spec("pytest_benchmark") is not None
 
 if HAS_BENCHMARK:
     def test_benchmark_text_string_to_metric_families(benchmark):