Skip to content

Commit 757abe8

Browse files
committed
Use object instead of Any for labels() parameters
Signed-off-by: Grégoire Deveaux <gregoire.deveaux@gitguardian.com>
1 parent 7819d80 commit 757abe8

1 file changed

Lines changed: 7 additions & 7 deletions

File tree

prometheus_client/metrics.py

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -135,7 +135,7 @@ def __init__(self: T,
135135
if registry:
136136
registry.register(self)
137137

138-
def labels(self: T, *labelvalues: Any, **labelkwargs: Any) -> T:
138+
def labels(self: T, *labelvalues: object, **labelkwargs: object) -> T:
139139
"""Return the child for the given labelset.
140140
141141
All metrics can have labels, allowing grouping of related time series.
@@ -173,13 +173,13 @@ def labels(self: T, *labelvalues: Any, **labelkwargs: Any) -> T:
173173
if labelkwargs:
174174
if sorted(labelkwargs) != sorted(self._labelnames):
175175
raise ValueError('Incorrect label names')
176-
labelvalues = tuple(str(labelkwargs[l]) for l in self._labelnames)
176+
str_labelvalues = tuple(str(labelkwargs[l]) for l in self._labelnames)
177177
else:
178178
if len(labelvalues) != len(self._labelnames):
179179
raise ValueError('Incorrect label count')
180-
labelvalues = tuple(str(l) for l in labelvalues)
180+
str_labelvalues = tuple(str(l) for l in labelvalues)
181181
with self._lock:
182-
if labelvalues not in self._metrics:
182+
if str_labelvalues not in self._metrics:
183183

184184
original_name = getattr(self, '_original_name', self._name)
185185
namespace = getattr(self, '_namespace', '')
@@ -190,17 +190,17 @@ def labels(self: T, *labelvalues: Any, **labelkwargs: Any) -> T:
190190
for k in ('namespace', 'subsystem', 'unit'):
191191
child_kwargs.pop(k, None)
192192

193-
self._metrics[labelvalues] = self.__class__(
193+
self._metrics[str_labelvalues] = self.__class__(
194194
original_name,
195195
documentation=self._documentation,
196196
labelnames=self._labelnames,
197197
namespace=namespace,
198198
subsystem=subsystem,
199199
unit=unit,
200-
_labelvalues=labelvalues,
200+
_labelvalues=str_labelvalues,
201201
**child_kwargs
202202
)
203-
return self._metrics[labelvalues]
203+
return self._metrics[str_labelvalues]
204204

205205
def remove(self, *labelvalues: Any) -> None:
206206
if 'prometheus_multiproc_dir' in os.environ or 'PROMETHEUS_MULTIPROC_DIR' in os.environ:

0 commit comments

Comments
 (0)