fix: resolve CI failures by normalizing line endings (LF), fixing path separators, and adding DCO sign-off

Signed-off-by: pittu sharma <pittusharma47@gmail.com>

Author: Pittu-Sharma

.gitattributes

@@ -0,0 +1,12 @@
+* text=auto eol=lf
+*.go text eol=lf
+*.md text eol=lf
+*.sh text eol=lf
+*.prom text eol=lf
+*.out text eol=lf
+*.txt text eol=lf
+*.yml text eol=lf
+*.yaml text eol=lf
+Makefile text eol=lf
+VERSION text eol=lf
+ttar text eol=lf

Makefile

@@ -116,8 +116,8 @@ update_fixtures:
 
 .PHONY: tools
 tools:
-	@rm ./tools/tools >/dev/null 2>&1 || true
-	@$(GO) build -o tools ./tools/...
+	@rm -f ./tools/tools
+	@$(GO) build -o tools/tools ./tools/main.go
 
 .PHONY: test-e2e
 test-e2e: build collector/fixtures/sys/.unpacked collector/fixtures/udev/.unpacked tools

collector/textfile.go

@@ -175,7 +175,7 @@ func (c *textFileCollector) exportMTimes(mtimes map[string]time.Time, ch chan<-
 		if c.mtime != nil {
 			mtime = *c.mtime
 		}
-		ch <- prometheus.MustNewConstMetric(mtimeDesc, prometheus.GaugeValue, mtime, path)
+		ch <- prometheus.MustNewConstMetric(mtimeDesc, prometheus.GaugeValue, mtime, filepath.ToSlash(path))
 	}
 }
 
@@ -208,12 +208,11 @@ func (c *textFileCollector) Update(ch chan<- prometheus.Metric) error {
 		}
 
 		for _, f := range files {
-			metricsFilePath := filepath.Join(path, f.Name())
 			if !strings.HasSuffix(f.Name(), ".prom") {
 				continue
 			}
-
 			mtime, families, err := c.processFile(path, f.Name(), ch)
+			metricsFilePath := filepath.ToSlash(filepath.Join(path, f.Name()))
 
 			for _, mf := range families {
 				// Check for metrics with inconsistent help texts and take the first help text occurrence.

docs/METRICS.md

@@ -1,4 +1,4 @@
-# Node Exporter Metrics
+# Node Exporter Metrics
 
 This file is auto-generated by `tools/doc_generator/main.go`.
 
@@ -248,7 +248,7 @@ This file is auto-generated by `tools/doc_generator/main.go`.
 | node_nfsd_read_ahead_cache_size_blocks | How large the read ahead cache is in blocks. | nfsd |
 | node_nfsd_reply_cache_hits_total | Total number of NFSd Reply Cache hits (client lost server response). | nfsd |
 | node_nfsd_reply_cache_misses_total | Total number of NFSd Reply Cache an operation that requires caching (idempotent). | nfsd |
-| node_nfsd_reply_cache_nocache_total | Total number of NFSd Reply Cache non-idempotent operations (rename/delete/…). | nfsd |
+| node_nfsd_reply_cache_nocache_total | Total number of NFSd Reply Cache non-idempotent operations (rename/delete/…). | nfsd |
 | node_nfsd_requests_total | Total number NFSd Requests by method and protocol. | nfsd |
 | node_nfsd_rpc_errors_total | Total number of NFSd RPC errors by error type. | nfsd |
 | node_nfsd_server_rpcs_total | Total number of NFSd RPCs. | nfsd |
@@ -456,7 +456,7 @@ This file is auto-generated by `tools/doc_generator/main.go`.
 | node_wifi_station_transmit_failed_total | The total number of times a station has failed to send a packet. | wifi |
 | node_wifi_station_transmit_retries_total | The total number of times a station has had to retry while sending a packet. | wifi |
 | node_wifi_station_transmitted_packets_total | The total number of packets transmitted by a station. | wifi |
-| node_xfrm_acquire_error_packets_total | State hasnΓÇÖt been fully acquired before use | xfrm |
+| node_xfrm_acquire_error_packets_total | State hasn’t been fully acquired before use | xfrm |
 | node_xfrm_fwd_hdr_error_packets_total | Forward routing of a packet is not allowed | xfrm |
 | node_xfrm_in_buffer_error_packets_total | No buffer is left | xfrm |
 | node_xfrm_in_error_packets_total | All errors not matched by other | xfrm |

tools/doc_generator/main.go

@@ -33,12 +33,12 @@ type metric struct {
 }
 
 type collectorInfo struct {
-	name             string
-	files            []string
-	metrics          []metric
-	flags            []flagInfo
-	dataSources      []string
-	platforms        []string
+	name        string
+	files       []string
+	metrics     []metric
+	flags       []flagInfo
+	dataSources []string
+	platforms   []string
 }
 
 type flagInfo struct {
@@ -246,11 +246,19 @@ func main() {
 	}
 
 	// Output global METRICS.md
-	fmt.Println("# Node Exporter Metrics")
-	fmt.Println("\nThis file is auto-generated by `tools/doc_generator/main.go`.")
-	fmt.Println("\n| Metric | Description | Collector |")
-	fmt.Println("| --- | --- | --- |")
-	
+	metricsFile := filepath.Join("docs", "METRICS.md")
+	mf, err := os.Create(metricsFile)
+	if err != nil {
+		fmt.Fprintf(os.Stderr, "Error creating %s: %v\n", metricsFile, err)
+		os.Exit(1)
+	}
+	defer mf.Close()
+
+	fmt.Fprintln(mf, "# Node Exporter Metrics")
+	fmt.Fprintln(mf, "\nThis file is auto-generated by `tools/doc_generator/main.go`.")
+	fmt.Fprintln(mf, "\n| Metric | Description | Collector |")
+	fmt.Fprintln(mf, "| --- | --- | --- |")
+
 	keys := make([]string, 0, len(collectors))
 	for k := range collectors {
 		keys = append(keys, k)
@@ -260,7 +268,7 @@ func main() {
 	for _, k := range keys {
 		c := collectors[k]
 		for _, m := range c.metrics {
-			fmt.Printf("| %s | %s | %s |\n", m.name, m.help, c.name)
+			fmt.Fprintf(mf, "| %s | %s | %s |\n", m.name, m.help, c.name)
 		}
 	}
 
@@ -276,7 +284,7 @@ func main() {
 			fmt.Fprintf(os.Stderr, "Error creating %s: %v\n", filename, err)
 			continue
 		}
-		
+
 		fmt.Fprintf(f, "# %s collector\n\n", c.name)
 		fmt.Fprintf(f, "The %s collector exposes metrics about %s.\n\n", c.name, c.name)
 
@@ -306,7 +314,7 @@ func main() {
 				fmt.Fprintf(f, "| %s | %s | %s |\n", m.name, m.help, labels)
 			}
 		}
-		
+
 		f.Close()
 	}
 }