Skip to content

Commit bffaeac

Browse files
prombotSuperQ
andauthored
Synchronize common files from prometheus/prometheus (#3553)
* Update common Prometheus files Signed-off-by: prombot <prometheus-team@googlegroups.com> * Fix lint issue > S1009: should omit nil check; len() for nil slices is defined as zero Signed-off-by: Ben Kochie <superq@gmail.com> --------- Signed-off-by: prombot <prometheus-team@googlegroups.com> Signed-off-by: Ben Kochie <superq@gmail.com> Co-authored-by: Ben Kochie <superq@gmail.com>
1 parent 32a7180 commit bffaeac

4 files changed

Lines changed: 13 additions & 11 deletions

File tree

.github/workflows/container_description.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ jobs:
1818
if: github.repository_owner == 'prometheus' || github.repository_owner == 'prometheus-community' # Don't run this workflow on forks.
1919
steps:
2020
- name: git checkout
21-
uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6.0.1
21+
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
2222
with:
2323
persist-credentials: false
2424
- name: Set docker hub repo name
@@ -42,7 +42,7 @@ jobs:
4242
if: github.repository_owner == 'prometheus' || github.repository_owner == 'prometheus-community' # Don't run this workflow on forks.
4343
steps:
4444
- name: git checkout
45-
uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6.0.1
45+
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
4646
with:
4747
persist-credentials: false
4848
- name: Set quay.io org name

.github/workflows/golangci-lint.yml

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,13 +3,15 @@
33
name: golangci-lint
44
on:
55
push:
6+
branches: [main, master, 'release-*']
67
paths:
78
- "go.sum"
89
- "go.mod"
910
- "**.go"
1011
- "scripts/errcheck_excludes.txt"
1112
- ".github/workflows/golangci-lint.yml"
1213
- ".golangci.yml"
14+
tags: ['v*']
1315
pull_request:
1416

1517
permissions: # added using https://github.com/step-security/secure-repo
@@ -24,13 +26,13 @@ jobs:
2426
runs-on: ubuntu-latest
2527
steps:
2628
- name: Checkout repository
27-
uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6.0.1
29+
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
2830
with:
2931
persist-credentials: false
3032
- name: Install Go
31-
uses: actions/setup-go@4dc6199c7b1a012772edbd06daecab0f50c9053c # v6.1.0
33+
uses: actions/setup-go@7a3fe6cf4cb3a834922a1244abfce67bcef6a0c5 # v6.2.0
3234
with:
33-
go-version: 1.25.x
35+
go-version: 1.26.x
3436
- name: Install snmp_exporter/generator dependencies
3537
run: sudo apt-get update && sudo apt-get -y install libsnmp-dev
3638
if: github.repository == 'prometheus/snmp_exporter'

Makefile.common

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -55,13 +55,13 @@ ifneq ($(shell command -v gotestsum 2> /dev/null),)
5555
endif
5656
endif
5757

58-
PROMU_VERSION ?= 0.17.0
58+
PROMU_VERSION ?= 0.18.0
5959
PROMU_URL := https://github.com/prometheus/promu/releases/download/v$(PROMU_VERSION)/promu-$(PROMU_VERSION).$(GO_BUILD_PLATFORM).tar.gz
6060

6161
SKIP_GOLANGCI_LINT :=
6262
GOLANGCI_LINT :=
6363
GOLANGCI_LINT_OPTS ?=
64-
GOLANGCI_LINT_VERSION ?= v2.7.2
64+
GOLANGCI_LINT_VERSION ?= v2.10.1
6565
GOLANGCI_FMT_OPTS ?=
6666
# golangci-lint only supports linux, darwin and windows platforms on i386/amd64/arm64.
6767
# windows isn't included here because of the path separator being different.

collector/perf_linux.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -327,7 +327,7 @@ func NewPerfCollector(logger *slog.Logger) (Collector, error) {
327327
}
328328

329329
// First configure any tracepoints.
330-
if *perfTracepointFlag != nil && len(*perfTracepointFlag) > 0 {
330+
if len(*perfTracepointFlag) > 0 {
331331
tracepointCollector, err := newPerfTracepointCollector(logger, *perfTracepointFlag, cpus)
332332
if err != nil {
333333
return nil, err
@@ -337,7 +337,7 @@ func NewPerfCollector(logger *slog.Logger) (Collector, error) {
337337

338338
// Configure perf profilers
339339
hardwareProfilers := perf.AllHardwareProfilers
340-
if *perfHwProfilerFlag != nil && len(*perfHwProfilerFlag) > 0 {
340+
if len(*perfHwProfilerFlag) > 0 {
341341
// hardwareProfilers = 0
342342
for _, hf := range *perfHwProfilerFlag {
343343
if v, ok := perfHardwareProfilerMap[hf]; ok {
@@ -346,7 +346,7 @@ func NewPerfCollector(logger *slog.Logger) (Collector, error) {
346346
}
347347
}
348348
softwareProfilers := perf.AllSoftwareProfilers
349-
if *perfSwProfilerFlag != nil && len(*perfSwProfilerFlag) > 0 {
349+
if len(*perfSwProfilerFlag) > 0 {
350350
// softwareProfilers = 0
351351
for _, sf := range *perfSwProfilerFlag {
352352
if v, ok := perfSoftwareProfilerMap[sf]; ok {
@@ -355,7 +355,7 @@ func NewPerfCollector(logger *slog.Logger) (Collector, error) {
355355
}
356356
}
357357
cacheProfilers := perf.L1DataReadHitProfiler | perf.L1DataReadMissProfiler | perf.L1DataWriteHitProfiler | perf.L1InstrReadMissProfiler | perf.InstrTLBReadHitProfiler | perf.InstrTLBReadMissProfiler | perf.DataTLBReadHitProfiler | perf.DataTLBReadMissProfiler | perf.DataTLBWriteHitProfiler | perf.DataTLBWriteMissProfiler | perf.LLReadHitProfiler | perf.LLReadMissProfiler | perf.LLWriteHitProfiler | perf.LLWriteMissProfiler | perf.BPUReadHitProfiler | perf.BPUReadMissProfiler
358-
if *perfCaProfilerFlag != nil && len(*perfCaProfilerFlag) > 0 {
358+
if len(*perfCaProfilerFlag) > 0 {
359359
cacheProfilers = 0
360360
for _, cf := range *perfCaProfilerFlag {
361361
if v, ok := perfCacheProfilerMap[cf]; ok {

0 commit comments

Comments
 (0)