ci(docker): build and publish linux/riscv64 images#3578
ci(docker): build and publish linux/riscv64 images#3578benevolentshrine wants to merge 1 commit intoprometheus:masterfrom
Conversation
|
This needs a DCO sign-off. You can use |
benevolentshrine
force-pushed
the
feat/riscv64-docker-images
branch
from
7242104 to
ef9f55d
Compare
|
Hey @SuperQ! All checks are passing including DCO ✅, would love to get your eyes on this when you get a chance. Happy to make any changes if needed! |
SuperQ
left a comment
SuperQ
left a comment
There was a problem hiding this comment.
Let's fix the sort order while we're here.
| !.build/linux-amd64 | ||
| !.build/linux-armv7 | ||
| !.build/linux-arm64 | ||
| !.build/linux-ppc64le | ||
| !.build/linux-s390x | ||
| !.build/linux-riscv64 |
There was a problem hiding this comment.
| !.build/linux-riscv64 | |
| !.build/linux-amd64 | |
| !.build/linux-arm64 | |
| !.build/linux-armv7 | |
| !.build/linux-ppc64le | |
| !.build/linux-riscv64 | |
| !.build/linux-s390x |
benevolentshrine
force-pushed
the
feat/riscv64-docker-images
branch
from
809bf7b to
82617c1
Compare
|
Can you fix the commit history here? |
benevolentshrine
force-pushed
the
feat/riscv64-docker-images
branch
2 times, most recently
from
99dc128 to
662fdd6
Compare
|
Hey @SuperQ! Applied your suggestions and cleaned up the commit history. All checks passing including DCO ✅, ready for your re-review when you get a chance! |
|
Sorry, it looks like the suggestions were not applied correctly and the git history is still incorrect. |
benevolentshrine
force-pushed
the
feat/riscv64-docker-images
branch
from
840a004 to
a1cbf81
Compare
Adds riscv64 to DOCKER_ARCHS in Makefile and un-ignores .build/linux-riscv64 in .dockerignore. Fixes prometheus#3311 Signed-off-by: benevolentshrine <proffersor45@gmail.com>
benevolentshrine
force-pushed
the
feat/riscv64-docker-images
branch
from
3eeb6de to
d1c11b6
Compare
|
Hey @SuperQ fixed the commit history, only one clean commit now. Ready for re-review |
|
Hello, 1.11.1 has the images. Note that quay.io does not seem to support them so you'd need to fetch them from e.g. docker hub. |
4 participants
Adds linux/riscv64 support for Docker image builds.
Fixes #3311
Changes
riscv64toDOCKER_ARCHSin Makefile.build/linux-riscv64in .dockerignoreNotes
Previously attempted in #3312 but was closed when the author deleted
their repository. That PR had received LGTM from a member and was
awaiting final review from @SuperQ.