From a59d368d3de9283cbb20ea279678472496f4f590 Mon Sep 17 00:00:00 2001 From: winston Date: Wed, 8 Apr 2026 05:02:12 -0700 Subject: [PATCH] fix(diskstats): only fail on mutually exclusive when present https://github.com/prometheus/node_exporter/pull/3603 introduced a subtle regression for existing configs where device-exclude was intentionally set to `=''` to clear the Linux default. This breaks configs that are valid (exclude is intentionally cleared). Update the mutual exclusivity check to only fail when the value is non-empty. Signed-off-by: winston --- collector/diskstats_common.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/collector/diskstats_common.go b/collector/diskstats_common.go index 543d9ea4c9..9d4158c0a7 100644 --- a/collector/diskstats_common.go +++ b/collector/diskstats_common.go @@ -100,7 +100,7 @@ func newDiskstatsDeviceFilter(logger *slog.Logger) (deviceFilter, error) { } } if *diskstatsDeviceInclude != "" { - if diskstatsDeviceExcludeSet { + if diskstatsDeviceExcludeSet && *diskstatsDeviceExclude != "" { return deviceFilter{}, errors.New("device-exclude & device-include are mutually exclusive") } *diskstatsDeviceExclude = ""